#34 add base url for service #35
Conversation
internal/app/app.go
Outdated
| rs := stats.NewKOReaderPGStats(pg) | ||
|
|
||
| // HTTP Server | ||
| handler := gin.New() |
There was a problem hiding this comment.
I think we can simplify implementation, crate RouterGroup with prefix here, and then forwared it to the NewRouter without changes to the code
There was a problem hiding this comment.
router := gin.New()
handler := r.Group(cfg.Urlprefix)
|
Okay, after several attempts, I have now set urlprefix in the global. Please review it. I am still not very familiar with Golang and Gin, so if there are any misunderstandings, please let me know. |
|
Please Review it. |
|
Hi — sorry to bother. I wanted to follow up on this PR and ask whether there’s anything preventing it from being merged. If the patch doesn’t meet the project’s standards, has too many commits and should be split/rebased, or if it introduces regressions or otherwise breaks the project, I’m happy to revise it however you prefer. I’d really like to help make this project better. Please let me know what I can change. Thanks for your time |
2 participants
#34 . Add baseurl support for service with environment
KOMPANION_URL_PREFIX