rmdir: Remove all trailing slashes when checking for symlinks #9983
+27
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cerdelen
force-pushed
the
rmdir_trailing_slashes
branch
from
f8d06ec to
0caada3
Compare
rmdir: cargo fmt l
cerdelen
force-pushed
the
rmdir_trailing_slashes
branch
from
0caada3 to
2b4b6df
Compare
cerdelen
changed the title
cerdelen
changed the title
Contributor
|
Could you please add a test to make sure we don't regress in the future? |
sylvestre
reviewed
Jan 2, 2026
cerdelen
force-pushed
the
rmdir_trailing_slashes
branch
from
26ad0a8 to
df6288f
Compare
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking for symlinks on unix trailing slashes need to be removed. Until no only 1 trailing slash was removed resulting in a different error message if the given argument included multiple trailing slashes.
Fixes: #9980