date:ethiopian calendar function #9923
Draft
+390
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored date iteration in uumain to extract valid dates early and handle invalid dates with error messages immediately. - Improved strftime preprocessing in system_time.rs to support additional format specifiers (%N, %q, %:z, %::z, %:::z) using jiff, ensuring consistent behavior across Unix systems.
… improved readability - Simplified jdn calculation in gregorian_to_ethiopian by removing line breaks - Condensed jiff_format return statement onto one line - Moved consume_repeats function signature to a single line - These changes enhance code compactness without altering functionality
- Introduce format_nanos_padded() and format_nanos_trimmed() helper functions - Modify preprocess_format() to handle %-N, outputting nanoseconds without trailing zeros - Retain %N for padded nanoseconds (09 digits) to maintain backward compatibility
- Rename variables in gregorian_to_ethiopian for better readability - Add nanos_to_u32 function to validate nanosecond values and prevent out-of-range errors - Replace unsafe pointer casts with safe alternatives using cast_mut and from_ref - Update format! calls to use named parameters for consistency
- Merge the first two terms of the Julian Day Number formula into a single line to improve code formatting and consistency without altering functionality.
Contributor
|
sorry but my concerns are still there :) |
…anosecond formatting Extract julian_day_number and ethiopian_year_and_day functions to improve readability and modularity in gregorian_to_ethiopian. Introduce nanos_from and format_nanos_for_flag to simplify nanosecond handling in preprocess_format, reducing code duplication.
…e for conciseness Refactor the day-of-year calculation in system_time.rs to merge the addition of the two main terms onto one line, improving code readability without altering functionality.
Contributor
Author
Should I create a PR just for the conversion code to ethiopia? |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
Implement a function to convert the Ethiopian calendar
related
gnu coreutils test
date-ethiopia.sh