Add SMACK support to id, mkdir, mkfifo, mknod utilities

[ChrisDryden]

This is the third PR based off of the following prototype: #9866

Now the original SMACK implementation for ls is implemented alongside the CI runner for the SMACK GNU tests and now its time to actually implement SMACK support for the different utilities.

[ChrisDryden]

This is unrelated to the SMACK fixes, but I am unsure as to why we need this linux and android flag here if we are targeting the SELINUX feature

[codspeed-hq]

CodSpeed Performance Report

Merging #9910 will degrade performance by 5.89%

_{Comparing ChrisDryden:smack-utility-support (d482e41) with main (1eea517)}

Summary

❌ 10 regressions
✅ 126 untouched
⏩ 24 skipped¹

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	BASE	HEAD	Efficiency
❌	wc_bytes_synthetic[500]	185.2 µs	191.7 µs	-3.37%
❌	dd_copy_partial	550.8 µs	571.7 µs	-3.65%
❌	factor_multiple_u64s[2]	212.3 ms	225.6 ms	-5.89%
❌	sort_ascii_utf8_locale	22.2 ms	23.6 ms	-5.78%
❌	b64_encode_synthetic	161.9 µs	169.4 µs	-4.44%
❌	b64_decode_synthetic	166.3 µs	171.8 µs	-3.19%
❌	b64_decode_ignore_garbage_synthetic	163.2 µs	169.7 µs	-3.81%
❌	rm_single_file	119.3 ms	124.3 ms	-4%
❌	mv_single_file	135.5 ms	141.4 ms	-4.13%
❌	mv_force_overwrite	144.3 ms	150 ms	-3.79%

Footnotes

1. 24 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[ChrisDryden]

I'm not sure why the GNU comment is not posting?

I'm seeing this in the workflow but it didn't post the comment
Notice: Congrats! The gnu test tests/id/smack is no longer failing!
Notice: Congrats! The gnu test tests/mkdir/smack-no-root is no longer failing!
Notice: Congrats! The gnu test tests/mkdir/smack-root is no longer failing!

[sylvestre]

i can take some time

also, please fix:

  error: redundant else block
     --> src/uu/id/src/id.rs:186:14
      |
  186 |               } else {
      |  ______________^
  187 | |                 return Err(USimpleError::new(
  188 | |                     1,
  189 | |                     translate!("id-error-cannot-get-context"),
  190 | |                 ));
  191 | |             }
      | |_____________^
      |
      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#redundant_else
      = note: `-D clippy::redundant-else` implied by `-D warnings`
      = help: to override `-D warnings` add `#[allow(clippy::redundant_else)]`
  help: remove the `else` block and move the contents out
      |
  186 ~             }
  187 +             return Err(USimpleError::new(
  188 +                 1,
  189 +                 translate!("id-error-cannot-get-context"),
  190 +             ));
      |

[ChrisDryden]

As a note about the performance regressions, its from the default locale file growing bigger. This can be improved by duplicating it to the individual utility locales, could go either way, just leaving it in the main locale file for now.

[sylvestre]

As a note about the performance regressions, its from the default locale file growing bigger. This can be improved by duplicating it to the individual utility locales, could go either way, just leaving it in the main locale file for now.

We should work on this at some point, we should not have such perf regressions for a few strings

[github-actions]

GNU testsuite comparison:

Congrats! The gnu test tests/id/smack is no longer failing!
Congrats! The gnu test tests/mkdir/smack-no-root is no longer failing!
Congrats! The gnu test tests/mkdir/smack-root is no longer failing!

[ChrisDryden]

Created an issue to track the shared locale files impacting performance: #9932 I think its a combination of gating the locale files based on feature flag and also coming up with mechanisms to reduce the burden that locales have on performance

[github-actions]

GNU testsuite comparison:

Congrats! The gnu test tests/id/smack is no longer failing!
Congrats! The gnu test tests/mkdir/smack-no-root is no longer failing!
Congrats! The gnu test tests/mkdir/smack-root is no longer failing!

[github-actions]

GNU testsuite comparison:

Congrats! The gnu test tests/id/smack is no longer failing!
Congrats! The gnu test tests/mkdir/smack-no-root is no longer failing!
Congrats! The gnu test tests/mkdir/smack-root is no longer failing!