feat(split): Add localized value names #9906
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Completing my PR (#9898) which would fully localize
splithelp text.If this PR is accepted I will be updating each packages which would close #9118.
Implementation :
It's manual work. Just replaced every call to
.value_name("<str>")by.value_name(translate!("<id>"))and updated the.ftlfiles accordingly. There is a risk that it slows down the program significantly because I had to add the "string" feature for clap and I don't know how much dynamic objects are costly for clap.If this is really costly, then these updates should wait the implementation of lazy loading of locales (#9103), or never be done if no solution, because performance is more important than some translations.
Testing :
My previous PR was compiled and tested with the value names changed. All tests passed so I conclude that it would be the same here.
Results :
Using the AUR version (0.5.0) :
Using my compiled version :