Skip to content

wc:Ensure the output order of stdout and stderror remains unchanged. #9905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mattsu2020 wants to merge 6 commits into
base: main
Choose a base branch
from
Open

wc:Ensure the output order of stdout and stderror remains unchanged. #9905

mattsu2020 wants to merge 6 commits into from

Conversation

@mattsu2020
Copy link
Contributor

@mattsu2020 mattsu2020 commented Dec 29, 2025 •
edited
Loading

Ensure the output order of stdout and stderror remains unchanged.
We'll flash it to keep the order unchanged.

related
#9863

mattsu2020 and others added 4 commits December 29, 2025 18:29
@mattsu2020
fix: Defer printing wc I/O errors from word counting until after st…
3d37e1c 
…atistics output, matching GNU behavior.
@mattsu2020
refactor: reformat CountResult::Interrupted arm for improved readab…
e9070a9 
…ility
@mattsu2020
fix(wc): flush stdout before printing deferred error
a2fd722 
Ensure deferred error messages are printed after all stats output, matching GNU wc behavior. Added io::stdout().flush() to guarantee buffered output is written before showing the error.
@sylvestre
Merge branch 'main' into wc_-9863
370c178
@sylvestre
Copy link
Contributor

sylvestre commented Dec 29, 2025

please add a test

@mattsu2020
test: add test for wc error handling with stderr redirected to stdout
de4a98f 
Add a new Unix-specific test case to verify that `wc` correctly handles reading from a directory when stderr is redirected to stdout, ensuring error messages appear in the expected order alongside the output. This improves test coverage for edge cases in error redirection.
@github-actions
Copy link

github-actions bot commented Dec 30, 2025

GNU testsuite comparison:

Note: The gnu test tests/id/smack was skipped on 'main' but is now failing.
Note: The gnu test tests/mkdir/smack-no-root was skipped on 'main' but is now failing.
Note: The gnu test tests/mkdir/smack-root was skipped on 'main' but is now failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mattsu2020 @sylvestre