Skip to content

Conversation

@oech3
Copy link
Contributor

@oech3 oech3 commented Dec 23, 2025

We should pass someday. Keep marking them failing.

@github-actions
Copy link

GNU testsuite comparison:

Note: The gnu test tests/tail/inotify-dir-recreate is now being skipped but was previously passing.

@oech3 oech3 marked this pull request as ready for review December 23, 2025 15:15
@sylvestre
Copy link
Contributor

not sure i see the difference between false and removing them

@oech3
Copy link
Contributor Author

oech3 commented Dec 24, 2025 via email

@oech3
Copy link
Contributor Author

oech3 commented Dec 24, 2025

@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/tty/tty-eof. tests/tty/tty-eof is passing on 'main'. Maybe you have to rebase?

@oech3
Copy link
Contributor Author

oech3 commented Dec 29, 2025

coreutils/util/build-gnu.sh

Lines 355 to 358 in bea05bb

# Disable this test, it is not relevant for us:
# * the selinux crate is handling errors
# * the test says "maybe we should not fail when no context available"
"${SED}" -i -e "s|returns_ 1||g" tests/cp/no-ctx.sh

?

@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/cp/no-ctx. tests/cp/no-ctx is passing on 'main'. Maybe you have to rebase?
Note: The gnu test tests/csplit/csplit-heap is now being skipped but was previously passing.
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.
Note: The gnu test tests/rm/many-dir-entries-vs-OOM is now being skipped but was previously passing.

@sylvestre
Copy link
Contributor

GNU testsuite comparison:

GNU test failed: tests/cp/no-ctx. tests/cp/no-ctx is passing on 'main'. Maybe you have to rebase?
Note: The gnu test tests/csplit/csplit-heap is now being skipped but was previously passing.
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.
Note: The gnu test tests/rm/many-dir-entries-vs-OOM is now being skipped but was previously passing.

i guess it is unexpected, no ?

@oech3
Copy link
Contributor Author

oech3 commented Dec 31, 2025 via email

@oech3
Copy link
Contributor Author

oech3 commented Dec 31, 2025

I will revert no-ctx after CI's traffic jam was solved.

@oech3 oech3 marked this pull request as draft December 31, 2025 03:17
@oech3 oech3 force-pushed the patch-2 branch 3 times, most recently from 26b031f to be38d39 Compare December 31, 2025 15:28
@oech3 oech3 marked this pull request as ready for review December 31, 2025 15:39
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 31, 2025

CodSpeed Performance Report

Merging #9796 will improve performance by 3.67%

Comparing oech3:patch-2 (be38d39) with main (fd68328)1

Summary

⚡ 1 improvement
✅ 135 untouched
⏩ 15 skipped2

Benchmarks breakdown

Benchmark BASE HEAD Efficiency
cp_large_file[16] 362.2 µs 349.4 µs +3.67%

Footnotes

  1. No successful run was found on main (c8c412c) during the generation of this report, so fd68328 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 15 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants