-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
build-gnu.sh: Fail 2 help-version*.sh instead of removing #9796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
GNU testsuite comparison: |
|
not sure i see the difference between false and removing them |
|
Removing tests masks existense of tests from people completely. This method lists them to failing tests and someone saw them might interested in them.
|
|
Like https://github.com/uutils/coreutils/actions/runs/20464039880/job/58803258630?pr=9796#step:11:262 . |
|
GNU testsuite comparison: |
|
Lines 355 to 358 in bea05bb
? |
|
GNU testsuite comparison: |
i guess it is unexpected, no ? |
|
unexpected
|
|
I will revert |
26b031f to
be38d39
Compare
CodSpeed Performance ReportMerging #9796 will improve performance by 3.67%Comparing Summary
Benchmarks breakdown
Footnotes
|
We should pass someday. Keep marking them failing.