Skip to content

cp: Preserve mode for directories when copying by default. #9794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
nikolalukovic wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

cp: Preserve mode for directories when copying by default. #9794

nikolalukovic wants to merge 4 commits into from

Conversation

@nikolalukovic
Copy link

@nikolalukovic nikolalukovic commented Dec 23, 2025

Attempts to fix: #7961

@nikolalukovic nikolalukovic force-pushed the fix/7961 branch 2 times, most recently from e5a0699 to e96a0d6 Compare December 23, 2025 14:21
@github-actions
Copy link

github-actions bot commented Dec 23, 2025

GNU testsuite comparison:

GNU test failed: tests/cp/existing-perm-dir. tests/cp/existing-perm-dir is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/csplit/csplit-heap is now being skipped but was previously passing.
Note: The gnu test tests/cut/cut-huge-range is now being skipped but was previously passing.
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.
Note: The gnu test tests/tail/inotify-dir-recreate is now being skipped but was previously passing.

@github-actions
Copy link

github-actions bot commented Dec 23, 2025

GNU testsuite comparison:

GNU test failed: tests/cp/existing-perm-dir. tests/cp/existing-perm-dir is passing on 'main'. Maybe you have to rebase?
Note: The gnu test tests/tail/inotify-dir-recreate is now being skipped but was previously passing.

@nikolalukovic nikolalukovic force-pushed the fix/7961 branch 2 times, most recently from aa40f09 to de4e3ec Compare December 23, 2025 16:19
@github-actions
Copy link

github-actions bot commented Dec 23, 2025

GNU testsuite comparison:

GNU test failed: tests/cp/existing-perm-dir. tests/cp/existing-perm-dir is passing on 'main'. Maybe you have to rebase?
Note: The gnu test tests/tail/inotify-dir-recreate is now being skipped but was previously passing.

@nikolalukovic nikolalukovic marked this pull request as draft December 23, 2025 20:41
sylvestre
sylvestre reviewed Dec 23, 2025
View reviewed changes
tests/uutests/src/lib/util.rs Outdated
/// # Panics
///
/// This function panics if there is an error loading the metadata
#[cfg(not(windows))]
Copy link
Contributor

@sylvestre sylvestre Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this function into test_cp.rs please

@github-actions
Copy link

github-actions bot commented Dec 29, 2025

GNU testsuite comparison:

Note: The gnu test tests/id/smack was skipped on 'main' but is now failing.
Note: The gnu test tests/mkdir/smack-no-root was skipped on 'main' but is now failing.
Note: The gnu test tests/mkdir/smack-root was skipped on 'main' but is now failing.

@github-actions
Copy link

github-actions bot commented Dec 31, 2025

GNU testsuite comparison:

GNU test failed: tests/cp/preserve-mode. tests/cp/preserve-mode is passing on 'main'. Maybe you have to rebase?

@github-actions
Copy link

github-actions bot commented Dec 31, 2025

GNU testsuite comparison:

GNU test failed: tests/cp/preserve-mode. tests/cp/preserve-mode is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/tail/retry. tests/tail/retry is passing on 'main'. Maybe you have to rebase?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sylvestre sylvestre sylvestre left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cp behaves differently on read-only directories

2 participants

@nikolalukovic @sylvestre