feat(df): add thousands separator support

src/uu/df/src/df.rs

@@ -167,6 +167,7 @@ impl Options {
                 ),
                 ParseSizeError::ParseFailure(s) => OptionsError::InvalidBlockSize(s),
                 ParseSizeError::PhysicalMem(s) => OptionsError::InvalidBlockSize(s),
+                ParseSizeError::BuilderConfig(e) => OptionsError::InvalidBlockSize(e.to_string()),
             })?,
             header_mode: {
                 if matches.get_flag(OPT_HUMAN_READABLE_BINARY)

src/uu/du/src/du.rs

@@ -1490,6 +1490,9 @@ fn format_error_message(error: &ParseSizeError, s: &str, option: &str) -> String
         ParseSizeError::SizeTooBig(_) => {
             translate!("du-error-argument-too-large", "option" => option, "value" => s.quote())
         }
+        ParseSizeError::BuilderConfig(e) => {
+            format!("invalid configuration for {option}: {e}")
+        }
     }
 }
 

src/uu/od/src/od.rs

@@ -804,5 +804,8 @@ fn format_error_message(error: &ParseSizeError, s: &str, option: &str) -> String
         ParseSizeError::SizeTooBig(_) => {
             translate!("od-error-argument-too-large", "option" => option, "value" => s.quote())
         }
+        ParseSizeError::BuilderConfig(e) => {
+            format!("invalid configuration for {option}: {e}")
+        }
     }
 }

src/uu/sort/src/sort.rs

@@ -319,10 +319,10 @@ impl GlobalSettings {
         // GNU sort (8.32) invalid:  b, B, 1B,                         p, e, z, y
         let size = Parser::default()
             .with_allow_list(&[
-                "b", "k", "K", "m", "M", "g", "G", "t", "T", "P", "E", "Z", "Y", "R", "Q", "%",
-            ])
-            .with_default_unit("K")
-            .with_b_byte_count(true)
+                "b", "k", "K", "m", "M", "g", "G", "t", "T", "P", "E", "Z", "Y", "R", "Q",
+            ])?
+            .with_default_unit("K")?
+            .with_b_byte_count(true)?
             .parse(input.trim())?;
 
         usize::try_from(size).map_err(|_| {
@@ -2268,6 +2268,9 @@ fn format_error_message(error: &ParseSizeError, s: &str, option: &str) -> String
         ParseSizeError::SizeTooBig(_) => {
             translate!("sort-option-arg-too-large", "option" => option, "arg" => s.quote())
         }
+        ParseSizeError::BuilderConfig(e) => {
+            format!("invalid configuration for {option}: {e}")
+        }
     }
 }
 

src/uucore/src/lib/features/i18n/decimal.rs

@@ -12,7 +12,7 @@ use icu_provider::prelude::*;
 use crate::i18n::get_numeric_locale;
 
 /// Return the decimal separator for the given locale
-fn get_decimal_separator(loc: Locale) -> String {
+fn get_decimal_separator(loc: &Locale) -> String {
     let data_locale = DataLocale::from(loc);
 
     let request = DataRequest {
@@ -34,7 +34,7 @@ fn get_decimal_separator(loc: Locale) -> String {
 pub fn locale_decimal_separator() -> &'static str {
     static DECIMAL_SEP: OnceLock<String> = OnceLock::new();
 
-    DECIMAL_SEP.get_or_init(|| get_decimal_separator(get_numeric_locale().0.clone()))
+    DECIMAL_SEP.get_or_init(|| get_decimal_separator(&get_numeric_locale().0))
 }
 
 #[cfg(test)]
@@ -45,7 +45,7 @@ mod tests {
 
     #[test]
     fn test_simple_separator() {
-        assert_eq!(get_decimal_separator(locale!("en")), ".");
-        assert_eq!(get_decimal_separator(locale!("fr")), ",");
+        assert_eq!(get_decimal_separator(&locale!("en")), ".");
+        assert_eq!(get_decimal_separator(&locale!("fr")), ",");
     }
 }