Skip to content

Conversation

@oech3
Copy link
Contributor

@oech3 oech3 commented Jan 3, 2026

Closes #10002

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 3, 2026

CodSpeed Performance Report

Merging #10031 will degrade performance by 99.78%

Comparing oech3:cksum3b (41a4c3c) with main (81ee8d1)

Summary

❌ 1 regression
✅ 138 untouched
⏩ 37 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Efficiency
cksum_blake3 209.7 µs 93,293.4 µs -99.78%

Footnotes

  1. 37 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@oech3
Copy link
Contributor Author

oech3 commented Jan 3, 2026

So we were benching blake3's error message...

@github-actions
Copy link

github-actions bot commented Jan 3, 2026

GNU testsuite comparison:

GNU test failed: tests/shuf/shuf-reservoir. tests/shuf/shuf-reservoir is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/sort/sort-stale-thread-mem. tests/sort/sort-stale-thread-mem is passing on 'main'. Maybe you have to rebase?
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.

@oech3 oech3 changed the title cksum: Back -a blake3 cksum: Back support for -a blake3 and -a shake* Jan 4, 2026
@oech3 oech3 force-pushed the cksum3b branch 4 times, most recently from cd502e9 to 73260a4 Compare January 4, 2026 00:57
@github-actions
Copy link

github-actions bot commented Jan 4, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@oech3
Copy link
Contributor Author

oech3 commented Jan 4, 2026

@sylvestre No performance regression by this PR. We were benchmarking a bunch of error messages for broken cksum -a blake3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cksum: unknown algorithm: blake3: clap should have prevented this case

1 participant