-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
join: add benchmarks #10005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
join: add benchmarks #10005
Conversation
|
i wrote: #9991 |
Oh, sorry I didn't notice. I'll close it. |
|
well, we can keep yours :) |
|
just add it to github action and just keep one value for the bench (and move it into the function) |
14ed820 to
7872ed5
Compare
|
thanks for the review |
CodSpeed Performance ReportMerging #10005 will not alter performanceComparing Summary
Benchmarks breakdown
Footnotes
|
|
please keep 3 benchmarks, we probably don't need 6 as they take a long time to run |
ok |
7872ed5 to
54f2354
Compare
|
oh, please create a new bench marking (same file) with the French locale to compare with the current other pr |
do it in another PR? |
|
Yes please |
Supplement to #9982