Skip to content

Conversation

@WaterWhisperer
Copy link
Contributor

Supplement to #9982

@sylvestre
Copy link
Contributor

i wrote: #9991

@WaterWhisperer
Copy link
Contributor Author

i wrote: #9991

Oh, sorry I didn't notice. I'll close it.

@sylvestre
Copy link
Contributor

well, we can keep yours :)

@sylvestre sylvestre reopened this Jan 3, 2026
@sylvestre
Copy link
Contributor

just add it to github action and just keep one value for the bench (and move it into the function)

@WaterWhisperer
Copy link
Contributor Author

thanks for the review

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 3, 2026

CodSpeed Performance Report

Merging #10005 will not alter performance

Comparing WaterWhisperer:join-benchmark (54f2354) with main (ea64612)

Summary

✅ 135 untouched
🆕 3 new
⏩ 37 skipped1

Benchmarks breakdown

Benchmark BASE HEAD Efficiency
🆕 join_partial_overlap N/A 10.5 ms N/A
🆕 join_custom_separator N/A 12.1 ms N/A
🆕 join_full_match N/A 12.8 ms N/A

Footnotes

  1. 37 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@sylvestre
Copy link
Contributor

please keep 3 benchmarks, we probably don't need 6 as they take a long time to run

@WaterWhisperer
Copy link
Contributor Author

please keep 3 benchmarks, we probably don't need 6 as they take a long time to run

ok

@sylvestre sylvestre merged commit e4d35b0 into uutils:main Jan 3, 2026
130 checks passed
@sylvestre
Copy link
Contributor

oh, please create a new bench marking (same file) with the French locale to compare with the current other pr
thanks

@WaterWhisperer
Copy link
Contributor Author

oh, please create a new bench marking (same file) with the French locale to compare with the current other pr thanks

do it in another PR?

@sylvestre
Copy link
Contributor

Yes please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants