Fix LSP races #893
Merged
Fix LSP races #893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toinehartman
added
bug
toinehartman
force-pushed
the
fix/892-lsp-races
branch
3 times, most recently
from
08fefa5 to
41ca7f2
Compare
This makes sure the order of incoming LSP requests is maintained, preventing races in downstream workers.
toinehartman
force-pushed
the
fix/892-lsp-races
branch
from
41ca7f2 to
92708f5
Compare
toinehartman
force-pushed
the
fix/892-lsp-races
branch
2 times, most recently
from
22577ce to
efbea10
Compare
toinehartman
force-pushed
the
fix/892-lsp-races
branch
from
c493cef to
5fb73f7
Compare
This reverts commit 025f31d.
DavyLandman
approved these changes
Nov 25, 2025
rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/parametric/model/ParametricFileFacts.java
Outdated
Show resolved
Hide resolved
rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/parametric/ParametricLanguageServer.java
Outdated
Show resolved
Hide resolved
rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/parametric/ParserOnlyContribution.java
Outdated
Show resolved
Hide resolved
rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/rascal/RascalLanguageServer.java
Outdated
Show resolved
Hide resolved
|
DavyLandman
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LSP requests now in come in on multiple threads, which makes their order unpredictable. This causes subtle bugs, like #630 (which will be solved in a separate PR: #633).
CompletableFutureagain and make sure they use the proper cached thread pool.CompletableFuture::completedFutureand use cached thread pool, so any chained futures are on the proper thread.Closes #892.