Skip to content

Conversation

@karlhorky
Copy link
Member

@karlhorky karlhorky commented Sep 9, 2024

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 9, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions
Copy link

github-actions bot commented Sep 9, 2024

size-limit report 📦

Path Size
dist/preflight.esm.js 6.4 KB (0%)

@karlhorky
Copy link
Member Author

Confirmed that CI is passing in 565baed

Reverted the Node.js version change in 08ed9c6

We will have to wait until Node.js v22 enters LTS in October to merge this one.

@karlhorky
Copy link
Member Author

Ok, I'm wrong - it seems like the latest workflow test run passed... 🤔

So maybe there were multiple Windows long pathname bugs in Node.js, and maybe this one was fixed in the earlier PR?

Either way, it's passing now, so we can already merge now 🙌

@karlhorky karlhorky merged commit 7b7d78b into main Sep 9, 2024
@karlhorky karlhorky deleted the upgrade-to-node-22-and-remove-windows-long-path-workarounds branch September 9, 2024 14:43
@karlhorky
Copy link
Member Author

karlhorky commented Oct 26, 2024

I encountered this problem again today in a new test run:

[FAILED] Command failed with exit code 2: eslint . --max-warnings 0 --format json


Oops! Something went wrong! :(

ESLint: 9.13.0

Error: Cannot find package 'D:\a\preflight\preflight\__tests__\fixtures\__temp\react-passing\node_modules\.pnpm\eslint-config-upleveled@8.11.2_@babel+core@7.26.0_@types+eslint@8.44.8_@types+node@22.8.1_@ty_rtj346fr63svxtagmumvixsyhe\node_modules\eslint-plugin-react-compiler\dist\index.js' imported from D:\a\preflight\preflight\__tests__\fixtures\__temp\react-passing\node_modules\.pnpm\eslint-config-upleveled@8.11.2_@babel+core@7.26.0_@types+eslint@8.44.8_@types+node@22.8.1_@ty_rtj346fr63svxtagmumvixsyhe\node_modules\eslint-config-upleveled\index.js
Did you mean to import "eslint-plugin-react-compiler/dist/index.js"?
    at legacyMainResolve (node:internal/modules/esm/resolve:215:26)
    at packageResolve (node:internal/modules/esm/resolve:841:14)
    at moduleResolve (node:internal/modules/esm/resolve:927:18)
    at defaultResolve (node:internal/modules/esm/resolve:1169:11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:542:12)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:510:25)
    at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:239:38)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:96:40)
    at link (node:internal/modules/esm/module_job:95:36)

I guess the pnpm paths weren't long enough to trigger the errors.

Since Node.js v22 is becoming LTS imminently, I've upgraded ahead of time in our CI, which resolved the issue:

pnpm test

> @upleveled/preflight@8.0.4 test D:\a\preflight\preflight
> vitest run


 RUN  v2.1.3 D:/a/preflight/preflight

 ✓ __tests__/e2e.test.ts  (2 tests) 197938ms

 Test Files  1 passed (1)
      Tests  2 passed (2)
   Start at  17:22:45
   Duration  198.51s (transform 61ms, setup 0ms, collect 198ms, tests 197.94s, environment 0ms, prepare 106ms)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants