-
Notifications
You must be signed in to change notification settings - Fork 2
Feature: Pressure + Strain Service #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for pressure and strain measurements to the Argus system, completing the sensor suite alongside the existing temperature measurements. The changes remove the deprecated straingauge-converter and ads126x crates, refactor message generation to use a messages package prefix for Python imports, and introduce new protobuf message definitions for pressure and strain readings.
Key changes:
- Addition of pressure and strain measurement services, tasks, and types
- Removal of deprecated
ads126xdriver andstraingauge-convertercrates - Refactoring of protobuf Python package structure to use
messages.prefix - Introduction of
Nodeconcept to identify message sources in the envelope - Updates to calibration and linear transformation logic for both pressure and strain
Reviewed Changes
Copilot reviewed 93 out of 112 changed files in this pull request and generated 21 comments.
Show a summary per file
| File | Description |
|---|---|
common/messages/proto/argus/*.proto |
New protobuf definitions for pressure and strain channels/readings; updated envelope with Node |
common/messages/python/messages/**/*.py |
Regenerated Python protobuf files with messages. package prefix |
common/messages/utils/prefix-python-imports.sh |
New script to add package prefix to Python imports |
boards/argus/src/strain/** |
New strain measurement service, tasks, and types |
boards/argus/src/pressure/** |
Enhanced pressure service with calibration and updated reading structure |
boards/argus/src/node/mod.rs |
New node identification module for envelope creator metadata |
apps/argus/argus/**/*.py |
Updated Python app to handle new message types and package structure |
common/straingauge-converter/** |
Removed deprecated crate |
common/ads126x/** |
Removed deprecated ADC driver crate |
Comments suppressed due to low confidence (4)
common/straingauge-converter/Cargo.toml:1
- The Rust edition '2024' does not exist. Valid Rust editions are 2015, 2018, and 2021. This should be changed to 'edition = "2021"' before the file is deleted.
common/messages/python/messages/argus/service_pb2.py:26 - Import of 'argus_dot_envelope__pb2' is not used.
common/messages/python/messages/argus/temperature/thermocouple_reading_pb2.py:25 - Import of 'argus_dot_adc__pb2' is not used.
common/messages/python/messages/argus/temperature/thermocouple_reading_pb2.py:26 - Import of 'argus_dot_temperature_dot_thermocouple__channel__pb2' is not used.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.