Skip to content

Conversation

@darrenrahnemoon
Copy link
Member

No description provided.

@darrenrahnemoon darrenrahnemoon changed the title Feature: Pressure Service Feature: Pressure + Strain Service Oct 28, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for pressure and strain measurements to the Argus system, completing the sensor suite alongside the existing temperature measurements. The changes remove the deprecated straingauge-converter and ads126x crates, refactor message generation to use a messages package prefix for Python imports, and introduce new protobuf message definitions for pressure and strain readings.

Key changes:

  • Addition of pressure and strain measurement services, tasks, and types
  • Removal of deprecated ads126x driver and straingauge-converter crates
  • Refactoring of protobuf Python package structure to use messages. prefix
  • Introduction of Node concept to identify message sources in the envelope
  • Updates to calibration and linear transformation logic for both pressure and strain

Reviewed Changes

Copilot reviewed 93 out of 112 changed files in this pull request and generated 21 comments.

Show a summary per file
File Description
common/messages/proto/argus/*.proto New protobuf definitions for pressure and strain channels/readings; updated envelope with Node
common/messages/python/messages/**/*.py Regenerated Python protobuf files with messages. package prefix
common/messages/utils/prefix-python-imports.sh New script to add package prefix to Python imports
boards/argus/src/strain/** New strain measurement service, tasks, and types
boards/argus/src/pressure/** Enhanced pressure service with calibration and updated reading structure
boards/argus/src/node/mod.rs New node identification module for envelope creator metadata
apps/argus/argus/**/*.py Updated Python app to handle new message types and package structure
common/straingauge-converter/** Removed deprecated crate
common/ads126x/** Removed deprecated ADC driver crate
Comments suppressed due to low confidence (4)

common/straingauge-converter/Cargo.toml:1

  • The Rust edition '2024' does not exist. Valid Rust editions are 2015, 2018, and 2021. This should be changed to 'edition = "2021"' before the file is deleted.
    common/messages/python/messages/argus/service_pb2.py:26
  • Import of 'argus_dot_envelope__pb2' is not used.
    common/messages/python/messages/argus/temperature/thermocouple_reading_pb2.py:25
  • Import of 'argus_dot_adc__pb2' is not used.
    common/messages/python/messages/argus/temperature/thermocouple_reading_pb2.py:26
  • Import of 'argus_dot_temperature_dot_thermocouple__channel__pb2' is not used.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@darrenrahnemoon darrenrahnemoon merged commit b94a8dd into main Nov 1, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants