Skip to content

Conversation

@ljm42
Copy link
Member

@ljm42 ljm42 commented Dec 18, 2025

Before Submitting This PR, Please Ensure You Have Completed The Following:

  1. Are internal links to wiki documents using relative file links?
  2. Are all new documentation files lowercase, with dash separated names (ex. unraid-os.mdx)?
  3. Are all assets (images, etc), located in an assets/ subfolder next to the .md/mdx files?
  4. Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  5. Is the build succeeding?

Summary by CodeRabbit

  • Documentation
    • Added release notes for Unraid OS 7.2.3, documenting security and bugfix updates across Storage, webGUI, and system components. Includes Samba library updates, known issues, and upgrade/rollback guidance.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 18, 2025

📝 Walkthrough

Walkthrough

Adds release notes documentation for Unraid OS version 7.2.3 (2025-12-18), classified as a security and bugfix release. Documents fixes across Storage, webGUI, Misc, and Unraid API components, along with base distro updates including Samba 4.23.4.

Changes

Cohort / File(s) Summary
Release notes documentation
docs/unraid-os/release-notes/7.2.3.md
New release notes document for Unraid OS 7.2.3 containing upgrading guidance, security fixes, bug fixes across Storage, webGUI, Misc, and Unraid API domains, known issues, and rollback information.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

  • Pure documentation addition with no code or logic changes
  • Content verification for accuracy of listed fixes and version numbers may be beneficial

Poem

A bunny hops through release notes so fine,
Version 7.2.3 shines in the timeline,
Security patches and fixes galore,
Samba hops forward, what's not to adore? 🐰✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add 7.2.3 Release notes' clearly and concisely describes the main change—adding release notes for Unraid OS version 7.2.3, which aligns with the changeset.
Description check ✅ Passed The PR description matches the template structure exactly, including all five required checklist items for documentation submissions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch add-7-2-3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
docs/unraid-os/release-notes/7.2.3.md (1)

26-28: Minor: Consider more precise language on line 27.

The phrase "making it hard to read" is somewhat generic. A more specific alternative might strengthen the documentation.

🔎 Suggested revision:
-- Fix: Notification text is sometimes shown in wrong colors, making it hard to read
+- Fix: Notification text is sometimes shown in wrong colors, reducing readability

Per LanguageTool's suggestion, this is a minor style refinement for documentation quality.

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3cdaf36 and f8c0e22.

📒 Files selected for processing (1)
  • docs/unraid-os/release-notes/7.2.3.md (1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/unraid-os/release-notes/7.2.3.md

[style] ~27-~27: To elevate your writing, try using a synonym here.
Context: ...etimes shown in wrong colors, making it hard to read

  • Fix: Potential XSS issue whe...

(HARD_TO)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: deploy-preview
🔇 Additional comments (2)
docs/unraid-os/release-notes/7.2.3.md (2)

1-46: Document structure and content look solid.

The release notes are well-organized with clear sections, appropriate cross-references to prior releases, and proper acknowledgment of security fixes (line 28 XSS issue). File naming follows conventions (lowercase numeric version), and no asset folder is required since no images are referenced.

Verify this PR meets the pre-submission checklist items:

  • ✓ Internal links use relative file links
  • ✓ File is lowercase (7.2.3.md)
  • ✓ No assets to organize
  • Verify: No duplicate open PRs for 7.2.3 release notes
  • Verify: Build succeeds (link extension consistency confirmed)

7-8: The link extensions are correct. The referenced files exist with their respective extensions: 7.2.2.md (used in lines 11, 15, 17), upgrading-unraid.mdx (line 7), and licensing-faq.mdx (line 8). The different extensions reflect the actual file types in the repository, not an inconsistency.

Likely an incorrect or invalid review comment.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2025

PR Preview Action v1.6.3
Preview removed because the pull request was closed.
2025-12-18 21:10 UTC

@ljm42 ljm42 merged commit 3f8dd0e into main Dec 18, 2025
3 checks passed
@ljm42 ljm42 deleted the add-7-2-3 branch December 18, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants