Refactor/nuxtui notifications #1817
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: ResolvedOrganizerView -> root is replaced by rootId + flatEntries. `root` resolved a tree representation of an organizer, but this required clients to defined and use their own tree operations, thus increasing client complexity. Instead, `flatEntries` is more suitable for client operations and only requires an initial mapping step on the client for efficiency.
…asts" This reverts commit b147762.
…e files Problem: ESLint was flagging auto-imported composables (like `useToast`) as undefined variables in `.vue` files. While TypeScript correctly identified these globals via `auto-imports.d.ts`, the default `no-undef` rule in our Vue ESLint config did not account for them, causing false positive linting errors. Solution: - Disable the `no-undef` rule specifically for `.vue` files in `eslint.config.mjs`. - Rely on TypeScript (via `vue-tsc`) and `auto-imports.d.ts` to handle global variable validation, ensuring type safety without conflicting with the auto-import build process. - Remove manual imports of `useToast` that were added as a workaround (p sure the path I used didn't even exist in node modules).
…ts to type declarations
…posable in ConnectSettings, DockerContainersTable, and RCloneOverview components
…ssages in RCloneConfig component
…r external URL handling across multiple components
…logging and improve extractGraphQLErrorMessage to handle additional error structures
…olors to streamline notification rendering across components
…d on notification data
Updates the notification sidebar to properly refresh notification counts (badges) when the API connection is restored or when the user manually retries. Changes: - Emit `refetched` event from `NotificationsList` when the query successfully returns data. - Trigger `recalculateOverview` and `refetch` in `Sidebar` when the list is refreshed or when the API status becomes 'online'. - Fixes an issue where notification badges would remain at 0 after an API outage, even though the notification list had populated correctly.
…uxtui toasts"" This reverts commit 2707f69.
- Added optional properties `expand`, `duration`, and `max` to the Notify interface. - Updated NotificationSettings class to include validation for new properties. - Modified the NotificationsService to parse and return the new settings. - Adjusted the toaster configuration in the app to utilize the new settings. - Updated GraphQL query to fetch the new notification settings.
…nd clean up imports - Created a new file for ToastPosition type definitions to improve code organization. - Removed the inline ToastPosition type definition from mount-engine.ts and updated the import accordingly. - Added a comment in app.config.ts for clarity on toaster settings.
…coping - Introduced a new class to modify the default base CSS file by wrapping content after the 'body' selector in a CSS scope. - Implemented methods to read the file, generate a patch, and apply the necessary modifications. - Added error handling for cases where the 'body' block cannot be found.
Azure theme causing problems because it's the only theme where the color of the icon can't be inverted (bruh)
3 tasks
3 tasks
This reverts commit bc0e2df.
Raised by [MitchellThompkins](https://github.com/MitchellThompkins) in #1848 - Documents how to use Docker to build a local Connect plugin - Local Plugin flow will now build workspace packages before proceeding with plugin infra + build - Removes recommendation to run `pnpm build:watch` from root, as this race conditions and build cache issues. - Makes `pnpm dev` from root parallel, preventing servers from blocking each other. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Updated development workflow documentation to emphasize Docker-based plugin builds * Restructured development modes into three workflows: local Docker builds, direct deployment, and development servers * Updated build and deployment instructions * **Chores** * Modified dev script for parallel execution * Refactored build scripts with improved dependency handling <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Previously, api plugins could only be installed as `peerDependencies` in the api. This change allows them to be listed as `dependencies` as well. This makes plugin loading (eg loading Connect) more robust. Tests: - [x] Re-logging on 7.3.0-beta.0.5
…ations. Supports 7.0-7.2.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Migrate Notification-related Components from Shadcn to Nuxtui
Summary of changes and notable additions:
webgui/emhttp/webGui/scripts/notify(and no this script did not check for the title size...see bug fixes below :/)NotificationSettingsto the graphql api model so we can sync toast position with legacy settingsBug Fixes
Some Notes
window.location.assignnot the:toprop as there is no vue router in a standalone component enviornment.Unfixed Bugs (issues need to be created)