-
Notifications
You must be signed in to change notification settings - Fork 15
New Crowdin updates #1809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
New Crowdin updates #1809
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1809 +/- ##
==========================================
- Coverage 52.04% 46.40% -5.64%
==========================================
Files 874 954 +80
Lines 50372 59770 +9398
Branches 5017 5541 +524
==========================================
+ Hits 26214 27734 +1520
- Misses 24083 31917 +7834
- Partials 75 119 +44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WalkthroughThis change adds a new translation key Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (24)
web/src/locales/ar.json(1 hunks)web/src/locales/bn.json(1 hunks)web/src/locales/ca.json(1 hunks)web/src/locales/cs.json(1 hunks)web/src/locales/da.json(1 hunks)web/src/locales/de.json(1 hunks)web/src/locales/es.json(1 hunks)web/src/locales/fr.json(1 hunks)web/src/locales/hi.json(1 hunks)web/src/locales/hr.json(1 hunks)web/src/locales/hu.json(1 hunks)web/src/locales/it.json(1 hunks)web/src/locales/ja.json(1 hunks)web/src/locales/ko.json(1 hunks)web/src/locales/lv.json(1 hunks)web/src/locales/nl.json(1 hunks)web/src/locales/no.json(1 hunks)web/src/locales/pl.json(1 hunks)web/src/locales/pt.json(1 hunks)web/src/locales/ro.json(1 hunks)web/src/locales/ru.json(1 hunks)web/src/locales/sv.json(1 hunks)web/src/locales/uk.json(1 hunks)web/src/locales/zh.json(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
web/**/*
📄 CodeRabbit inference engine (CLAUDE.md)
Always run
pnpm codegenfor GraphQL code generation in the web directory
Files:
web/src/locales/hr.jsonweb/src/locales/ro.jsonweb/src/locales/no.jsonweb/src/locales/nl.jsonweb/src/locales/ca.jsonweb/src/locales/de.jsonweb/src/locales/ko.jsonweb/src/locales/fr.jsonweb/src/locales/cs.jsonweb/src/locales/lv.jsonweb/src/locales/ru.jsonweb/src/locales/it.jsonweb/src/locales/da.jsonweb/src/locales/ja.jsonweb/src/locales/uk.jsonweb/src/locales/pt.jsonweb/src/locales/zh.jsonweb/src/locales/hu.jsonweb/src/locales/es.jsonweb/src/locales/pl.jsonweb/src/locales/hi.jsonweb/src/locales/ar.jsonweb/src/locales/sv.jsonweb/src/locales/bn.json
**/*
📄 CodeRabbit inference engine (.cursor/rules/default.mdc)
Never add comments unless they are needed for clarity of function
Files:
web/src/locales/hr.jsonweb/src/locales/ro.jsonweb/src/locales/no.jsonweb/src/locales/nl.jsonweb/src/locales/ca.jsonweb/src/locales/de.jsonweb/src/locales/ko.jsonweb/src/locales/fr.jsonweb/src/locales/cs.jsonweb/src/locales/lv.jsonweb/src/locales/ru.jsonweb/src/locales/it.jsonweb/src/locales/da.jsonweb/src/locales/ja.jsonweb/src/locales/uk.jsonweb/src/locales/pt.jsonweb/src/locales/zh.jsonweb/src/locales/hu.jsonweb/src/locales/es.jsonweb/src/locales/pl.jsonweb/src/locales/hi.jsonweb/src/locales/ar.jsonweb/src/locales/sv.jsonweb/src/locales/bn.json
🔇 Additional comments (23)
web/src/locales/hr.json (1)
33-33: Croatiancommon.retryentry looks correct and consistentKey name, placement after
common.learnMore, and translation “Pokušaj ponovo” are all appropriate; JSON remains valid.web/src/locales/da.json (1)
33-33: Danishcommon.retryentry is accurate“Prøv igen” correctly conveys “Retry”, and the key is added in the right place with valid JSON syntax.
web/src/locales/fr.json (1)
33-33: Frenchcommon.retrystring is appropriate“Réessayer” is a standard label for retry actions; key naming, ordering, and JSON formatting are all consistent.
web/src/locales/uk.json (1)
33-33: Ukrainiancommon.retrytranslation looks good“Спробувати знову” correctly expresses “Retry” in this UI context; JSON and key ordering are consistent with surrounding entries.
web/src/locales/pl.json (1)
33-33: Polishcommon.retrykey is structurally correctThe new key is well-placed and JSON-valid; “Ponów” is a concise, acceptable retry label in Polish.
web/src/locales/ja.json (1)
33-33: Japanesecommon.retryentry is correct“再試行” is the standard translation for “Retry”; key naming, ordering, and JSON formatting are all consistent with the rest of the file.
web/src/locales/hi.json (1)
33-33: Hindicommon.retrystring is accurate and consistently placed
"फिर से प्रयास करें"is a natural translation for a retry action, and the key fits correctly among the othercommon.*entries. Also, please ensurepnpm codegenhas been run inweb/after these changes, per the project guidelines forweb/**/*.web/src/locales/pt.json (1)
33-33: Portuguesecommon.retrytranslation looks good
"Tentar Novamente"is an appropriate label for a retry action and matches tone/capitalization of neighboringcommon.*strings.web/src/locales/ru.json (1)
33-33: Russiancommon.retrytranslation is appropriate
"Повторить"is the standard, concise Russian wording for a retry action and aligns with surroundingcommon.*labels.web/src/locales/ko.json (1)
33-33: Koreancommon.retrytranslation is correct
"재시도"is the expected Korean term for a retry action and is consistent with the style of the othercommon.*entries.web/src/locales/nl.json (1)
33-33: Dutchcommon.retrytranslation reads naturally
"Opnieuw proberen"is a natural Dutch label for retry and fits well with the surroundingcommon.*strings.web/src/locales/de.json (1)
33-33: Germancommon.retrytranslation is appropriate
"Erneut versuchen"is standard German UI phrasing for retry and matches the tone and casing of nearbycommon.*keys.web/src/locales/ro.json (1)
33-33: Romaniancommon.retrytranslation looks goodThe key placement and the translation “Reîncercați” are consistent with surrounding common.* entries and UI tone.
web/src/locales/cs.json (1)
33-33: Czechcommon.retryentry is appropriate“Opakovat” is an idiomatic retry label and matches the style of other common.* keys.
web/src/locales/es.json (1)
33-33: Spanishcommon.retrystring is consistent“Reintentar” matches existing button verb forms and correctly expresses “Retry”.
web/src/locales/no.json (1)
33-33: Norwegiancommon.retrytranslation is correct“Prøv på nytt” is idiomatic and consistent with the rest of the locale.
web/src/locales/ca.json (1)
33-33: Catalancommon.retryentry looks correct
"Torna-ho a provar"is an appropriate translation for “Retry”, and the JSON structure/placement amongcommon.*keys is valid.web/src/locales/lv.json (1)
33-33: Latviancommon.retryentry is valid
"Mēģināt vēlreiz"is a good fit for “Retry”, and the JSON remains syntactically correct.web/src/locales/sv.json (1)
33-33: Swedishcommon.retryentry is appropriate
"Försök igen"accurately conveys “Retry”, with correct JSON formatting and consistent key placement.web/src/locales/ar.json (1)
33-33: Arabiccommon.retryentry looks good
"إعادة المحاولة"is an appropriate translation for “Retry”, and the JSON remains well‑formed.web/src/locales/zh.json (1)
33-33: Chinesecommon.retryentry is correct
"重试"is the standard Simplified Chinese term for “Retry”, and the key fits cleanly into the existingcommon.*block.web/src/locales/it.json (1)
33-33: Italiancommon.retryentry is well‑formed
"Riprova"is an idiomatic Italian translation for “Retry”, and the JSON structure is intact.web/src/locales/bn.json (1)
33-33: ✓ Well-integrated localization entry.The new "common.retry" translation is properly formatted, correctly positioned in alphabetical order, and uses the appropriate Bengali translation. The change follows the existing structure and conventions in the file.
| "common.installed": "Telepítve", | ||
| "common.installing": "Telepítés folyamatban", | ||
| "common.learnMore": "Tudjon meg többet", | ||
| "common.retry": "Újra próbálkozik", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjust Hungarian common.retry to an imperative form
The current text “Újra próbálkozik” reads as a descriptive sentence rather than a button label. To match the polite imperative style used elsewhere in this locale, consider changing it to “Próbálja újra”.
Proposed diff
- "common.retry": "Újra próbálkozik",
+ "common.retry": "Próbálja újra",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "common.retry": "Újra próbálkozik", | |
| "common.retry": "Próbálja újra", |
🤖 Prompt for AI Agents
In web/src/locales/hu.json around line 33, the Hungarian value for
"common.retry" is currently a descriptive phrase ("Újra próbálkozik"); change it
to the polite imperative form used elsewhere by replacing it with "Próbálja
újra" so the label reads as a proper button/action command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
web/src/locales/ro.json (1)
33-33: Translation looks good, but consider alphabetical ordering.The Romanian translation "Reîncercați" for "common.retry" is correct. However, the key appears to be placed out of alphabetical order. Based on the alphabetical pattern in the rest of the
common.*namespace (cancel, close, continue, etc.),common.retryshould be positioned aftercommon.loading2(line 34) rather than before it, since "r" comes after "l" alphabetically.Since this is a Crowdin automated update, the ordering might be managed by external tooling or regenerated periodically. If alphabetical ordering is not enforced in your locale files, this can be safely ignored.
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (24)
web/src/locales/ar.json(1 hunks)web/src/locales/bn.json(1 hunks)web/src/locales/ca.json(1 hunks)web/src/locales/cs.json(1 hunks)web/src/locales/da.json(1 hunks)web/src/locales/de.json(1 hunks)web/src/locales/es.json(1 hunks)web/src/locales/fr.json(1 hunks)web/src/locales/hi.json(1 hunks)web/src/locales/hr.json(1 hunks)web/src/locales/hu.json(1 hunks)web/src/locales/it.json(1 hunks)web/src/locales/ja.json(1 hunks)web/src/locales/ko.json(1 hunks)web/src/locales/lv.json(1 hunks)web/src/locales/nl.json(1 hunks)web/src/locales/no.json(1 hunks)web/src/locales/pl.json(1 hunks)web/src/locales/pt.json(1 hunks)web/src/locales/ro.json(1 hunks)web/src/locales/ru.json(1 hunks)web/src/locales/sv.json(1 hunks)web/src/locales/uk.json(1 hunks)web/src/locales/zh.json(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
web/**/*
📄 CodeRabbit inference engine (CLAUDE.md)
Always run
pnpm codegenfor GraphQL code generation in the web directory
Files:
web/src/locales/de.jsonweb/src/locales/ru.jsonweb/src/locales/bn.jsonweb/src/locales/it.jsonweb/src/locales/lv.jsonweb/src/locales/pl.jsonweb/src/locales/cs.jsonweb/src/locales/zh.jsonweb/src/locales/ro.jsonweb/src/locales/ar.jsonweb/src/locales/da.jsonweb/src/locales/ko.jsonweb/src/locales/sv.jsonweb/src/locales/hu.jsonweb/src/locales/no.jsonweb/src/locales/pt.jsonweb/src/locales/fr.jsonweb/src/locales/uk.jsonweb/src/locales/ja.jsonweb/src/locales/ca.jsonweb/src/locales/hr.jsonweb/src/locales/es.jsonweb/src/locales/hi.jsonweb/src/locales/nl.json
**/*
📄 CodeRabbit inference engine (.cursor/rules/default.mdc)
Never add comments unless they are needed for clarity of function
Files:
web/src/locales/de.jsonweb/src/locales/ru.jsonweb/src/locales/bn.jsonweb/src/locales/it.jsonweb/src/locales/lv.jsonweb/src/locales/pl.jsonweb/src/locales/cs.jsonweb/src/locales/zh.jsonweb/src/locales/ro.jsonweb/src/locales/ar.jsonweb/src/locales/da.jsonweb/src/locales/ko.jsonweb/src/locales/sv.jsonweb/src/locales/hu.jsonweb/src/locales/no.jsonweb/src/locales/pt.jsonweb/src/locales/fr.jsonweb/src/locales/uk.jsonweb/src/locales/ja.jsonweb/src/locales/ca.jsonweb/src/locales/hr.jsonweb/src/locales/es.jsonweb/src/locales/hi.jsonweb/src/locales/nl.json
🔇 Additional comments (23)
web/src/locales/it.json (1)
33-33:common.retryentry looks correct and consistentThe Italian translation
"Riprova"is appropriate for a retry action and matches the style of neighboringcommon.*keys. Also, since this touchesweb/, please ensurepnpm codegenhas been run in thewebdirectory so any GraphQL-generated artifacts stay in sync (even if this PR doesn’t change GraphQL schema).web/src/locales/ru.json (1)
33-33:common.retryRussian translation LGTM
"Повторить"is a natural and consistent choice for a retry action alongside othercommon.*strings.web/src/locales/ca.json (1)
33-33:common.retryCatalan translation LGTM
"Torna-ho a provar"is an appropriate and consistent translation for the retry action.web/src/locales/pt.json (1)
33-33:common.retryPortuguese translation LGTM
"Tentar Novamente"is a clear, idiomatic label and matches the capitalization/style of neighboringcommon.*strings.web/src/locales/hr.json (1)
33-33:common.retryCroatian translation LGTM
"Pokušaj ponovo"is an appropriate, user-friendly translation for retry and aligns with the tone of othercommon.*labels.web/src/locales/hi.json (1)
33-33: Hindicommon.retrytranslation is appropriate
"फिर से प्रयास करें"correctly conveys a retry / try‑again action and matches surroundingcommon.*strings.web/src/locales/cs.json (1)
33-33: Czechcommon.retrytranslation is correct
"Opakovat"is a standard Czech label for retrying an action and fits the existingcommon.*set.web/src/locales/no.json (1)
33-33: Norwegiancommon.retrytranslation is idiomatic
"Prøv på nytt"is the expected wording for a retry button and aligns with surroundingcommon.*keys.web/src/locales/ko.json (1)
33-33: Koreancommon.retrytranslation is suitable
"재시도"is the conventional Korean label for a retry action and is consistent with the rest of thecommon.*entries.web/src/locales/ar.json (1)
33-33: Arabiccommon.retrytranslation is accurate
"إعادة المحاولة"correctly expresses a retry / try‑again action and matches the style of nearbycommon.*strings.web/src/locales/de.json (1)
33-33: Germancommon.retrytranslation is good
"Erneut versuchen"is the standard German translation for retry and fits with existingcommon.*keys.Likely an incorrect or invalid review comment.
web/src/locales/hu.json (1)
33-33: common.retry entry looks consistent and non‑breakingKey naming matches existing
common.*pattern and the value is a reasonable Hungarian equivalent for a retry action.web/src/locales/bn.json (1)
33-33: Bengali retry label is appropriate
"পুনরায় চেষ্টা করুন"is an appropriate imperative translation for a retry action and aligns with othercommon.*keys.web/src/locales/zh.json (1)
33-33: Chinese common.retry is correct and idiomatic
"重试"is the standard concise Chinese label for a retry action and fits the existingcommon.*group.web/src/locales/uk.json (1)
33-33: Ukrainian retry translation is clear and consistent
"Спробувати знову"clearly conveys a retry action and matches the tone of othercommon.*labels.web/src/locales/es.json (1)
33-33: Spanish common.retry string is appropriate
"Reintentar"is the expected Spanish label for a retry action and integrates cleanly with existingcommon.*entries.web/src/locales/nl.json (1)
33-33: Dutch retry label is correct and idiomatic
"Opnieuw proberen"is a natural Dutch translation for a retry action and fits the existingcommon.*block.web/src/locales/pl.json (1)
33-33: Polishcommon.retrytranslation is consistent
"Ponów"is a natural label for a retry action and its placement with othercommon.*keys looks correct. As a reminder for web changes, runpnpm codegenin theweb/directory so GraphQL artifacts stay in sync.web/src/locales/fr.json (1)
33-33: Frenchcommon.retrytranslation looks correct
"Réessayer"matches the intended “Retry” action and the new key fits cleanly into the existingcommon.*block.web/src/locales/sv.json (1)
33-33: Swedishcommon.retrytranslation looks correct
"Försök igen"is the standard Swedish phrasing for “Retry”, and the key is added consistently alongside othercommon.*strings.web/src/locales/da.json (1)
33-33: Danishcommon.retrytranslation looks correct
"Prøv igen"appropriately expresses a retry action and the key follows the existingcommon.*naming and placement.web/src/locales/lv.json (1)
33-33: Latviancommon.retrytranslation looks correct
"Mēģināt vēlreiz"is an appropriate label for “Retry”, and the new key is consistent with nearbycommon.*entries.web/src/locales/ja.json (1)
33-33: Japanesecommon.retrytranslation looks correct
"再試行"is the standard Japanese label for a retry action and the key integrates cleanly into the existingcommon.*section.
|
This plugin has been deployed to Cloudflare R2 and is available for testing. |
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.