Skip to content

fix: add empty transforms to the list of objects for making instances… #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sindharta-tanuwijaya merged 1 commit into from
Apr 6, 2023
Merged

fix: add empty transforms to the list of objects for making instances… #906

sindharta-tanuwijaya merged 1 commit into from
Apr 6, 2023

Conversation

@sindharta-tanuwijaya
Copy link
Collaborator

@sindharta-tanuwijaya sindharta-tanuwijaya commented Apr 6, 2023

  • Ensure parent objects are added when an object is created in a hierarchy with empty transforms.

  • Using existing method instead of new one

@schinkowski @sindharta
fix: add empty transforms to the list of objects for making instances (…
ea35479 
…#903)

* Ensure parent objects are added when an object is created in a hierarchy with empty transforms.

* Fix for compiler error in yamato

* Refactoring to make the code more complicated

* Using existing method instead of new one

(cherry picked from commit 81304e7)
@sindharta-tanuwijaya
Copy link
Collaborator Author

sindharta-tanuwijaya commented Apr 6, 2023

@schinkowski
I am creating this PR to merge
#903
to dev.

@sindharta-tanuwijaya sindharta-tanuwijaya merged commit efdbdf8 into dev Apr 6, 2023
@sindharta-tanuwijaya sindharta-tanuwijaya deleted the instance_parent_fix2 branch April 6, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sindharta-tanuwijaya @schinkowski