CLDR-18999 Fix generate
#94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
force-pushed
the
pretty-grouse
branch
from
2b54dce to
cb24cc6
Compare
srl295
approved these changes
Dec 1, 2025
| working-directory: cldr-json | ||
| run: | | ||
| cd cldr-json | ||
| echo "::group::Cleanup" |
Member
There was a problem hiding this comment.
Why did you drop these? they categorize the log lines in the output panel
Member
Author
There was a problem hiding this comment.
because I've made them separate steps, which are a better categorization
| exit 1 | ||
| fi | ||
|
|
||
| export MAVEN_OPTS="-Xmx16384m -Dexec.cleanupDaemonThreads=false" |
Member
There was a problem hiding this comment.
I would put this on cldr-config.sh so that it can be overridden but this is fine for now
Member
Author
There was a problem hiding this comment.
it was here before, just further down
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful run: https://github.com/unicode-org/cldr-json/actions/runs/19824526840
Works locally and in CI