Skip to content

Conversation

@srl295
Copy link
Member

@srl295 srl295 commented Sep 23, 2025

@robertbastian
Copy link
Member

I'd prefer to add this to cldr-generate-json.sh so that it also works locally

@srl295 srl295 closed this Sep 23, 2025
@srl295
Copy link
Member Author

srl295 commented Sep 23, 2025

@srl295 srl295 reopened this Sep 23, 2025
@srl295 srl295 marked this pull request as draft September 23, 2025 18:01
@srl295
Copy link
Member Author

srl295 commented Sep 23, 2025

@robertbastian leaving this open for now because it does actually work…

@robertbastian
Copy link
Member

hmm I tested mine locally with my local cldr repo

@srl295
Copy link
Member Author

srl295 commented Sep 23, 2025

hmm I tested mine locally with my local cldr repo

you might try a non-fork branch (like i did) and make sure it works there.

@srl295 srl295 marked this pull request as ready for review October 4, 2025 15:45
@srl295
Copy link
Member Author

srl295 commented Oct 4, 2025

hmm I tested mine locally with my local cldr repo

not the same as testing in an action

@srl295
Copy link
Member Author

srl295 commented Oct 4, 2025

@robertbastian i'm leaving both. GENERATE generates in the action, generate is within the script (currently broken). we can fix the script and remove GENERATE.

@srl295
Copy link
Member Author

srl295 commented Oct 13, 2025

@robertbastian any comment on this? It adds on to yours except the action works..

Copy link
Member

@robertbastian robertbastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

@srl295 srl295 merged commit 2da48b2 into main Oct 14, 2025
2 of 3 checks passed
@srl295 srl295 deleted the srl295/cldr-18999/json-auto-production branch October 14, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants