-
Notifications
You must be signed in to change notification settings - Fork 12
Fix port cutting z position #714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Smaller PRs can be easier to merge in so thanks for this change. I shall take a look soon |
…a/paramak into fix_port_cutting_z_position
RemDelaporteMathurin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some really tiny comments :-)
|
Thanks @RemDelaporteMathurin for the suggested changes |
…a/paramak into fix_port_cutting_z_position
…a/paramak into fix_port_cutting_z_position
Codecov Report
@@ Coverage Diff @@
## develop #714 +/- ##
========================================
Coverage 98.87% 98.87%
========================================
Files 68 68
Lines 4337 4352 +15
========================================
+ Hits 4288 4303 +15
Misses 49 49
Continue to review full report at Codecov.
|
|
Think this is ready to merge unless anyone has any suggestions? @RemDelaporteMathurin @shimwell |
…a/paramak into fix_port_cutting_z_position
|
Think this should be ready for merging @shimwell @RemDelaporteMathurin once tests pass |
Proposed changes
This PR partially replaces #610 by implementing the z_pos - center_point changes to the port cutters. This PR does NOT add automatic port cutting to reactors (like #610) - this will be done in a separate PR
Types of changes
What types of changes does your code introduce to the Paramak?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...