Skip to content

Conversation

@billingsley-john
Copy link

@billingsley-john billingsley-john commented Feb 4, 2021

Proposed changes

This PR partially replaces #610 by implementing the z_pos - center_point changes to the port cutters. This PR does NOT add automatic port cutting to reactors (like #610) - this will be done in a separate PR

Types of changes

What types of changes does your code introduce to the Paramak?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Pep8 applied
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@shimwell
Copy link
Collaborator

shimwell commented Feb 4, 2021

Smaller PRs can be easier to merge in so thanks for this change. I shall take a look soon

Copy link

@RemDelaporteMathurin RemDelaporteMathurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some really tiny comments :-)

@billingsley-john
Copy link
Author

Thanks @RemDelaporteMathurin for the suggested changes

@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #714 (ce3bdf7) into develop (3208686) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #714   +/-   ##
========================================
  Coverage    98.87%   98.87%           
========================================
  Files           68       68           
  Lines         4337     4352   +15     
========================================
+ Hits          4288     4303   +15     
  Misses          49       49           
Impacted Files Coverage Δ
...mak/parametric_components/port_cutters_circular.py 100.00% <100.00%> (ø)
.../parametric_components/port_cutters_rectangular.py 100.00% <100.00%> (ø)
paramak/parametric_shapes/extruded_mixed_shape.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3208686...ce3bdf7. Read the comment docs.

@billingsley-john
Copy link
Author

Think this is ready to merge unless anyone has any suggestions? @RemDelaporteMathurin @shimwell

@billingsley-john billingsley-john mentioned this pull request Feb 5, 2021
10 tasks
@billingsley-john
Copy link
Author

Think this should be ready for merging @shimwell @RemDelaporteMathurin once tests pass

@billingsley-john billingsley-john merged commit 1e96669 into develop Feb 16, 2021
@billingsley-john billingsley-john deleted the fix_port_cutting_z_position branch February 24, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants