This repository was archived by the owner on Jan 17, 2019. It is now read-only.
Python 3 support and newest version of fontTools #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom fontTools.ttLib.sfnt to fontTools.ttLib
This prevents the error:
[]python ./woff-info /tmp/aaa/f8.woff
Traceback (most recent call last):
File "./woff-info", line 3, in <module>
from woffTools.tools import info
File "/Users/<usename>/git/woffTools/Lib/woffTools/__init__.py", line 23, in <module>
from fontTools.ttLib.sfnt import getSearchRange
This prevents the error
[]python ./woff-info /tmp/aaa/f8.woff
Creating Info Report: /tmp/aaa/f8.woff...
Traceback (most recent call last):
File "./woff-info", line 5, in <module>
info.main()
File "/Users/<username>/git/woffTools/Lib/woffTools/tools/info.py", line 276, in main
html = reportInfo(font, fontPath)
File "/Users/<username>/git/woffTools/Lib/woffTools/tools/info.py", line 242, in reportInfo
writeFontFaceRule(font, fontPath, writer)
File "/Users/<username>/git/woffTools/Lib/woffTools/tools/info.py", line 210, in writeFontFaceRule
fontFaceRule = makeFontFaceRule(font, fontPath, doLocalSrc=False)
File "/Users/<username>/git/woffTools/Lib/woffTools/tools/css.py", line 226, in makeFontFaceRule
makeFontFaceFontFamily(font),
File "/Users/<username>/git/woffTools/Lib/woffTools/tools/css.py", line 54, in makeFontFaceFontFamily
familyName = _skimNameIDs(font, familyPriority)
File "/Users/<username>/git/woffTools/Lib/woffTools/tools/css.py", line 189, in _skimNameIDs
for nameRecord in font["name"].names:
File "/Library/Python/2.7/site-packages/fontTools/ttLib/ttFont.py", line 376, in __getitem__
if self._tableCache is not None:
File "/Users/<username>/git/woffTools/Lib/woffTools/__init__.py", line 82, in __getattr__
raise AttributeError(attr)
AttributeError: _tableCache
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for running on both Python 2 and 3. Tested with Python 2.7 and Python 3.6 and they gives the same output:
env PYTHONPATH=Lib/ python2.7 ./woff-all /tmp/woffTools/py2/f1.woffenv PYTHONPATH=Lib/ python3.6 ./woff-all /tmp/woffTools/py3/f1.woff