Refactor DataCore to use hooks system via HooksBase and HooksCore #8
+368
−104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a layered hooks architecture for callback management in DataCore, replacing direct callback storage with inherited hooks infrastructure. Callbacks now return void instead of transforming values.
Architecture Changes
New inheritance hierarchy:
onDestroy)onChange,onSet) with typed parametersCallback Signature Changes
Callbacks are now notification-only (void return):
Implementation Updates
DataBase.set() and WeakData.set() adapted to invoke callbacks without expecting transformed values:
Exports
Added
HooksCoreandHooksBaseto public API.Testing
Comprehensive test suite covers:
Original prompt
This pull request was created as a result of the following prompt from Copilot chat.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.