[pull] master from quran:master #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, all qaris default to qari id 0. This makes sense for all the Hafs masa7if, where sheikh Minshawi has qari id 0. For other qira'at, however, this might not be the best default. This allows us to set it per page type. Fixes #2414.
Add a setting to allow drawing a line before each line of the Quran text. This is mostly used for Naskh.
We only need kapt for Dagger for the app module (and, as of today, we can't yet use ksp Dagger here due to the interop with Anvil). This at least limits kapt usage only to the app module.
This was missing from the last PR, but should also be annotated.
Update dependency org.mockito:mockito-core to v5.9.0
Update dependency androidx.compose:compose-bom to v2024
Update dependency com.google.firebase:firebase-crashlytics to v18.6.1
Share AGP and Kotlin versions with build-logic
Update agp to v8.2.2
Update dependency com.google.cloud:google-cloud-speech to v4.29.0
On devices using the older navigation bar, the "apply" button is often obscured in portrait mode. This fixes it by adding padding underneath it.
Add padding at the bottom of the audio panel
Fixes for a plethora of crashes
This reverts commit 4d2a351. This is due to a binary incompatible change in Compose: https://issuetracker.google.com/issues/322214617
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )