[pull] master from curl:master #593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reported-by: Harry Sintonen Closes #20092
- drop unused `http.h` includes. - drop unused `http1.h` include. - drop unused `http2.h` includes. - vssh/ssh.h: drop unused `vssh.h` include. - urldata.h: drop unused protocol includes. - url: include `smtp.h` directly. - rtsp.h: include directly where used. - imap, smtp: drop redundant include, move another from .h to .c. Verified with an all non-unity CI run. Closes #20093
The cookie flushing (saving to a cookie jar) should only be done if a transfer has been started. This is now done by checking the cookies->running field, which is not reset in curl_easy_reset() so the saving works correctly even after a call to that. Follow-up to fd6eb8d Verified by test 1920 Reported-by: Alexander Batischev Fixes #20090 Closes #20094
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )