Skip to content

Provide connection data within popup #137 #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
zahardev wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Provide connection data within popup #137 #138

zahardev wants to merge 3 commits into from

Conversation

@zahardev
Copy link

@zahardev zahardev commented Jan 22, 2025

Provide connection data within popup

  • Send the granted event and provide the key when access is granted.
  • Send the granted event and provide the key immediately if access was previously granted.
  • Send the revoking event when when the Revoke Access button is clicked.

Possible future improvement: Revoke access via AJAX and send the revoked event.

@zahardev zahardev requested a review from zackkatz January 22, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zackkatz zackkatz Awaiting requested review from zackkatz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zahardev @zackkatz