integration-tests: Verify LUKS key & parallelize #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was `test-coreos-vm` for all. Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
Jakob-Naucke
force-pushed
the
extend-integration-tests
branch
2 times, most recently
from
9b7f1c3 to
02c276c
Compare
vendored, direct definitions appear to be unavailable from the internet Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
In integration tests, check not only that the disk is encrypted, but that the encryption key matches. Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
This reverts commit a4c708a. Use forced server-side apply to apply CRDs concurrently. Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
Jakob-Naucke
force-pushed
the
extend-integration-tests
branch
from
02c276c to
aa656e8
Compare
Contributor
|
Very nice, many thanks for the PR. Nothing to add if the tests are passing locally! |
alicefr
approved these changes
Jan 6, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alicefr, Jakob-Naucke The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify the LUKS key is the one we'd expect as per the secret.
Use forced SSA to apply CRDs and revive parallel integration tests.
Picks one commit also included in #112.