Skip to content

ci: Check logging code #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
robin-nitrokey merged 2 commits into from
Mar 11, 2025
Merged

ci: Check logging code #206

robin-nitrokey merged 2 commits into from
Mar 11, 2025

Conversation

@robin-nitrokey
Copy link
Member

@robin-nitrokey robin-nitrokey commented Mar 10, 2025 •
edited
Loading

This patch adds a check with --features log-all to the CI. Previously, we only checked with --all-features which also sets log-none and thus disables logging.

Fixes: #114

@robin-nitrokey robin-nitrokey merged commit 024e0ec into main Mar 11, 2025
2 checks passed
@robin-nitrokey robin-nitrokey deleted the log branch March 11, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sosthene-nitrokey sosthene-nitrokey sosthene-nitrokey approved these changes

@daringer daringer Awaiting requested review from daringer

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI doesn't check logs

3 participants

@robin-nitrokey @sosthene-nitrokey