Feature/layout changes #82
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaKhatri
reviewed
Sep 1, 2020
AdityaKhatri
reviewed
Sep 1, 2020
tnagorra
approved these changes
Sep 1, 2020
ShrawanBK
force-pushed
the
feature/layout-changes
branch
from
c1ae429 to
47b5b7d
Compare
AdityaKhatri
approved these changes
Sep 7, 2020
ShrawanBK
force-pushed
the
feature/layout-changes
branch
from
47b5b7d to
61119e3
Compare
tnagorra
reviewed
Sep 8, 2020
Comment on lines
+702
to
+704
| const healthNutritionWithName = this.getDonutDataWithName(healthNutrition); | ||
| const educationInvolvementWithName = this.getDonutDataWithName(educationInvolvement); | ||
| const childMonitoringVizDataWithName = this.getDonutDataWithName(childMonitoringVizData); |
Member
There was a problem hiding this comment.
Calling the same memoized function with three different values consecutively results in cache miss every time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.