Remove Json module #84
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'm reluctant to merge this PR because it breaks users still on the latest 1.7.2. TLC release, which does not bundle |
Contributor
Author
|
Ah. No worries, whenever is appropriate. |
lemmy
added a commit
to tlaplus/tlaplus
that referenced
this pull request
Feb 9, 2023
"The [Json] parser MAY silently ignore empty lines, e.g. \n\n". https://github.com/ndjson/ndjson-spec#32-parsing Corresponding commit in the CommunityModules: tlaplus/CommunityModules@e17420d (we maintain this fork because of tlaplus/CommunityModules#84 (comment) [Bug]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77. Got a conflict when modifying the Json module bundled with TLC locally, so finally got around to doing this.