Migrate android.support annotations and classes to AndroidX #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the Android implementation to replace deprecated android.support.* imports with their androidx.* equivalents. This ensures compatibility with modern React Native projects, which use AndroidX by default.
Changes Made
In RNPlayServicesLocationProvider.java:
Replaced android.support.annotation.NonNull with androidx.annotation.NonNull
Replaced android.support.v4.app.ActivityCompat with androidx.core.app.ActivityCompat
In Utils.java:
Replaced android.support.annotation.Nullable with androidx.annotation.Nullable
Why This Change Is Needed
The Android Support Library is deprecated and no longer maintained.
Newer React Native versions and Android builds require AndroidX.
Without this change, projects using AndroidX fail to compile when depending on this library.
Impact
No functional changes — only import updates.
Fully backward-compatible with AndroidX-enabled projects.