-
Notifications
You must be signed in to change notification settings - Fork 10
[Fix] unify benchmark tool by migrating to tilelang.profiler.do_bench #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @RMLYC, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the benchmarking infrastructure by migrating from a custom Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully unifies the benchmarking tool by migrating to tilelang.profiler.do_bench and aligns the benchmarking interface, which is a positive step towards improving consistency and maintainability. The removal of manual CUDA event timing in benchmarks/benchmark.py simplifies the code and leverages the dedicated profiling utility. The refactoring of imports in benchmarks/flash_attn/mha.py is also a good practice. However, a potential issue exists with the removal of tuple handling in baseline_program within mha.py, which might lead to incorrect latency measurements if the underlying flash_attn_interface.flash_attn_func returns a tuple.
|
These changes looks good to me, however there may be other issues in the code format:
|
9687ece to
7e673b1
Compare
Done |
|
all comment resolved and ci passed @xysmlx |
xiayuqing0622
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
baseline_profiletool withtilelang.profiler.do_benchprofilemodule