framehop: remove the allocation in signal handle of framehop #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
overvenus
approved these changes
Oct 14, 2025
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
| { | ||
| unsafe { UNWINDER.iter_frames(ctx, cb) }; | ||
| // For Linux, this `try_write` should always succeed, because `SIGPROF` will never be delivered to | ||
| // another thread while the signal handler is running. However, I'm not sure about other OSes, so |
There was a problem hiding this comment.
SIGPROFwill never be delivered to another thread while the signal handler is running
Why? Do you have any pointers to source/documentation how we can double check that?
There was a problem hiding this comment.
SIGPROF seem to be delivered concurrently to multiple threads , can you double check please https://gist.github.com/korniltsev-grafanista/340064ee2a80b0fe9f95f64b29b13879
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #281
FramehopUnwinderbefore the first call to theperf_signal_handler.backtrace-rs) in the future.spin::RwLockinstead of thestatic mut, though there is no safety issue actually.