Implement file uploads #722
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… storage configuration for imprints. Includes Rust models and GraphQL types for File and FileUpload.
ja573
requested changes
Dec 24, 2025
|
|
||
| #[cfg(feature = "backend")] | ||
| /// Parse a DOI into prefix and suffix | ||
| pub fn parse_doi(doi: &Doi) -> ThothResult<(String, String)> { |
Member
There was a problem hiding this comment.
The Doi struct already performs validation, implementing FromStr (check thoth-api/src/model/mod.rs), and can output the string without the domain using to_string() (impl Display).
Overall, it'd make more sense to add a couple of methods to impl Doi in the model: fn prefix(&self) -> String and fn suffix(&self) -> String
| _filter_param_3: Option<Self::FilterParameter3>, | ||
| _filter_param_4: Option<Self::FilterParameter4>, | ||
| ) -> ThothResult<i32> { | ||
| Err(ThothError::InternalError( |
| crate::model::publication::Publication::from_id(db, &publication_id)? | ||
| .publisher_id(db) | ||
| } | ||
| _ => Err(ThothError::InternalError( |
Member
There was a problem hiding this comment.
I've seen a bunch of ThothError::InternalError in the PR, but these are not internal errors but user input errors... So let's just create new variants for each of them in thoth-errors
Member
There was a problem hiding this comment.
you can make the whole module #[cfg(feature = "backend")] rather than each individual import/function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.