Skip to content

Change incorrect price attribute "currentCode" to "currencyCode" #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thiagolepidus merged 3 commits into from
Jun 2, 2025
Merged

Change incorrect price attribute "currentCode" to "currencyCode" #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ce2786
Fix incorrect price attribute
thiagolepidus Jun 2, 2025
c01c054
Fix unit tests
thiagolepidus Jun 2, 2025
b916875
Merge branch 'fix_price_attribute' into 'main'
thiagolepidus Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/GraphQL/Models/Price.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,14 @@ public function setPublicationId(?string $publicationId): void
$this->setData('publicationId', $publicationId);
}

public function getCurrentCode(): ?string
public function getCurrencyCode(): ?string
{
return $this->getData('currentCode');
return $this->getData('currencyCode');
}

public function setCurrentCode(?string $currentCode): void
public function setCurrencyCode(?string $currencyCode): void
{
$this->setData('currentCode', $currentCode);
$this->setData('currencyCode', $currencyCode);
}

public function getUnitPrice(): ?float
Expand Down
4 changes: 2 additions & 2 deletions tests/GraphQL/Models/PriceTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@ public function testGettersAndSetters(): void
$price = new Price();
$price->setPriceId($priceId);
$price->setPublicationId($publicationId);
$price->setCurrentCode($currentCode);
$price->setCurrencyCode($currentCode);
$price->setUnitPrice($unitPrice);

$this->assertSame($priceId, $price->getPriceId());
$this->assertSame($publicationId, $price->getPublicationId());
$this->assertSame($currentCode, $price->getCurrentCode());
$this->assertSame($currentCode, $price->getCurrencyCode());
$this->assertSame($unitPrice, $price->getUnitPrice());
}
}