-
Notifications
You must be signed in to change notification settings - Fork 16
Update Aptitude #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Aptitude #58
Conversation
|
GitHub has broken the .NET 8 installation on the Windows image. So the failure can be ignore and/or rebased onto master, where I ignore the failure. |
Xsear
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work
| // occurs often after TargetClear -> TargetSelf | ||
| foreach (var target in context.Targets) | ||
| { | ||
| context.Shard.EntityMan.Remove((IEntity)target); | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there some good reference examples?
Just slightly worried about deleting any type of target here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe effect 10130, which has TargetClear -> TargetSelf -> TargetOwnedDeployables -> DestroyAbilityObject
or ability 31280. Hardpoint delete me and my object ; Deletes object sitting on this hardpoint
that has it after TargetFromStatusEffect, or ability 39416 that has it after TargetCharacterNPCs.
Out of 1049 instances of the command in 766 cases there's chain: TargetClear -> TargetSelf -> DestroyAbilityObject
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This command throws me for a loop but there seems to be an association with a concept of "Loadout Enhancement Modules". My current assumption is that based on some value it picks one of the 11 register values, as in almost all of the instances these span a range, e.g. 0-1 in 0.1 steps, and so on.
UdpHosts/GameServer/Systems/Aptitude/Commands/Register/PeekRegisterCommand.cs
Outdated
Show resolved
Hide resolved
UdpHosts/GameServer/Systems/Aptitude/Commands/Target/PushTargetsCommand.cs
Show resolved
Hide resolved
e8ce905 to
cd8fb1d
Compare
PR changes few things based on comparing ability/status effect chains and their names from various patches: