Optimise PC regression

[mumichae]

No description provided.

[codecov]

Codecov Report

Attention: Patch coverage is 86.15385% with 9 lines in your changes missing coverage. Please review.

Project coverage is 58.93%. Comparing base (d357273) to head (c54ad5c).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
scib/metrics/pcr.py	84.48%	9 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #408      +/-   ##
==========================================
+ Coverage   58.01%   58.93%   +0.91%     
==========================================
  Files          22       22              
  Lines        1646     1690      +44     
==========================================
+ Hits          955      996      +41     
- Misses        691      694       +3     

Flag	Coverage Δ
unittests	58.93% <86.15%> (+0.91%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
scib/metrics/cell_cycle.py	89.58% <100.00%> (+0.22%)	⬆️
scib/preprocessing.py	19.06% <100.00%> (ø)
scib/metrics/pcr.py	85.71% <84.48%> (+4.55%)	⬆️

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[VladimirShitov]

Overall, looks super nice. Sometimes, the code is unclear. I left some comments on potential improvements :)

[VladimirShitov]

Looks great to me :)

[VladimirShitov]

Looks good in general :) I left a few questions

[mumichae]

Thanks, I addressed your comments, but only changed the linear regression part to use multiple regression. According to my tests the output is sufficiently similar