♻️ refactor(bash-aliases): clean up code and remove unnecessar… #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…env var - Removed the 'CI' environment variable from the bash-aliases feature as it was unnecessary. - Moved the RC snippet to 'scripts/rc_snippet.sh' for better organization. - Bumped the feature version in 'devcontainer-feature.json' to accommodate these changes.
…test-setup.sh' - Removed the remaining reference to the 'CI' environment variable in `00-test-setup.sh`. - This fix ensures that the test setup script no longer relies on the unnecessary 'CI' variable.
Move terminal configuration from install.sh to a dedicated rc_snippet.sh file, following the pattern used in bash-aliases feature. This improves code organization and maintainability. The shell config now: - Checks if running in VS Code terminal - Sets UV_CACHE_DIR to project's directory - Creates the cache directory if needed
Bump version after moving shell configuration to rc_snippet.sh and improving terminal integration.
Change test script interpreter from zsh to bash to improve compatibility, as bash is more commonly available on Linux systems. Changes: - Modified shebang in test scripts from #!/bin/zsh to #!/bin/bash - Updated test commands to use bash -ic instead of zsh -ic - Kept test functionality identical while using more portable shell
Re-add CI environment variable check in rc_snippet.sh as it's needed for test execution. The tests run in CI without the vscode terminal. Changes: - Restored CI check in rc_snippet.sh condition - Updated setup.sh to simulate both vscode and CI environments - Updated 00-test-setup.sh to verify CI env var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…y 'CI' env var