Skip to content

Conversation

@loureirorg
Copy link
Contributor

No description provided.

… resolution

Updated 'devcontainer-feature.json' for 'bash-aliases' and 'uv' features to use 'dependsOn' instead of 'installAfter' to ensure hard dependencies are correctly installed.
…bility in CI

Updated the test script to use 'bash -lc' instead of 'bash -ic' to ensure the aliases are loaded correctly in the CI environment.
Reverted the changes from 'bash -lc' back to 'bash -ic' and commented out a test that may be causing issues in the CI environment.
Commented out 'set -e' in the test script to capture error messages and debug the issue in the CI environment.
…s in CI

Switched back to 'bash -lc' in the test script to capture different error messages and debug the issue in the CI environment.
Refactored the test script by splitting it into setup and cases. Reloaded the rc file after setup instead of relying on 'bash -lc' for better compatibility.
- Split `test.sh` into modular components:
  - `test.sh` now contains non-user-defined code.
  - Added `setup.sh` for testing setup, which runs once per `devcontainer features test` execution.
  - Created `cases/` directory for test cases, each testing a group of related features.
  - Introduced `cases/__before.sh` to run before every test case.
- Updated test cases to properly test aliases:
  - Resolved issue where `check` command did not work directly with aliases.
  - Modified tests to use `echo "$(alias_command)"` or `zsh -ic alias_command`.

This refactoring enhances the test suite structure and improves reliability when testing aliases with the `check` function.
@loureirorg loureirorg merged commit dee94be into main Dec 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants