Move to not using multiaddr for config values #791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Sutula <hi@asutula.com>
jsign
approved these changes
Mar 3, 2021
Contributor
jsign
left a comment
jsign
left a comment
There was a problem hiding this comment.
Sounds good.
But maybe we should hold merging this until a next major version bump since this in theory is a breaking change. Not in the APIs, but in the flag/envs that people might already have and are forced to change.
api/client/utils_test.go
Outdated
|
|
||
| devnet := tests.LaunchDevnetDocker(t, 1, 300, ipfsAddrStr, false) | ||
| devnetAddr := util.MustParseAddr("/ip4/127.0.0.1/tcp/" + devnet.GetPort("7777/tcp")) | ||
| devnetAddr := "127.0.0.1/tcp/" + devnet.GetPort("7777/tcp") |
Contributor
There was a problem hiding this comment.
I guess this should be:
devnetAddr := "127.0.0.1:" + devnet.GetPort("7777/tcp")
Signed-off-by: Aaron Sutula <hi@asutula.com>
Member
Author
|
@jsign I realized there were other places, like docs strings and readme that needed to be updated. May want to take another look. Sure, we can keep this on a branch for now. But once this is used in Hub, and we need to deploy hub (still might be many days or a week or two out), we'll have to release this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per a conversation today with @sanderpick and @textileben . So far, I've only update the lotus address to be plain old
host:port, but we can take this all the way. Let me know what you think.