Skip to content

fix(redis): Use wait strategy instead of deprecated decorator #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rmnigm wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −13
Open

fix(redis): Use wait strategy instead of deprecated decorator #941

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c52dd4c
update redis container
rmnigm Dec 22, 2025
0a9bb27
fix linting
rmnigm Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions modules/redis/testcontainers/redis/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
from redis.asyncio import Redis as asyncRedis
from testcontainers.core.container import DockerContainer
from testcontainers.core.utils import raise_for_deprecated_parameter
from testcontainers.core.waiting_utils import wait_container_is_ready
from testcontainers.core.wait_strategies import ExecWaitStrategy


class RedisContainer(DockerContainer):
Expand All @@ -36,19 +36,14 @@ class RedisContainer(DockerContainer):

def __init__(self, image: str = "redis:latest", port: int = 6379, password: Optional[str] = None, **kwargs) -> None:
raise_for_deprecated_parameter(kwargs, "port_to_expose", "port")
super().__init__(image, **kwargs)
wait_strategy = ExecWaitStrategy(["redis-cli", "-a", password, "ping"] if password else ["redis-cli", "ping"])
super().__init__(image, _wait_strategy=wait_strategy, **kwargs)
self.port = port
self.password = password
self.with_exposed_ports(self.port)
if self.password:
self.with_command(f"redis-server --requirepass {self.password}")

@wait_container_is_ready(redis.exceptions.ConnectionError)
def _connect(self) -> None:
client = self.get_client()
if not client.ping():
raise redis.exceptions.ConnectionError("Could not connect to Redis")

def get_client(self, **kwargs) -> redis.Redis:
"""
Get a redis client.
Expand All @@ -66,11 +61,6 @@ def get_client(self, **kwargs) -> redis.Redis:
**kwargs,
)

def start(self) -> "RedisContainer":
super().start()
self._connect()
return self


class AsyncRedisContainer(RedisContainer):
"""
Expand Down