feat: Improve Unix socket connection handling for proxy compatibility #53
+121
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomhurst
force-pushed
the
feat/improve-unix-socket-handling
branch
from
771ee02 to
09cd6c3
Compare
- Use SocketsHttpHandler with ConnectCallback for .NET 8+ (more robust) - Add KeepAlive socket option for better proxy socket compatibility - Add configurable UnixSocketConnectTimeout (default 30s) - Improve error handling with proper socket disposal - Add unit tests for DockerClientConfiguration This change addresses issues with Docker socket proxy wrappers (like those used in some CI environments) that may not work with the legacy ManagedHandler. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
thomhurst
force-pushed
the
feat/improve-unix-socket-handling
branch
from
09cd6c3 to
f329d87
Compare
…n container log tests
There was a problem hiding this comment.
Pull request overview
This PR improves Unix socket connection handling to better support Docker socket proxy wrappers commonly used in CI environments like custom GitHub runners with Docker-in-Docker (DinD). The implementation adds configurable connection timeouts and switches to modern SocketsHttpHandler for .NET 8+.
Key Changes:
- Introduced
SocketConnectTimeoutconfiguration property with a 30-second default timeout - Migrated .NET 8+ Unix socket connections from
ManagedHandlertoSocketsHttpHandlerwithConnectCallback - Added
KeepAlivesocket option for improved proxy compatibility across all platforms
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
DockerClientConfiguration.cs |
Adds SocketConnectTimeout parameter/property with default value of 30 seconds |
DockerClient.cs |
Implements modern SocketsHttpHandler for .NET 8+ and timeout handling with KeepAlive for all platforms |
DockerClientConfigurationTests.cs |
New unit tests validating default and custom timeout configuration values |
IContainerOperationsTests.cs |
Changes ThrowsAsync to ThrowsAnyAsync for more accurate cancellation exception assertions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…entials and adding cancellation support
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves Unix socket connection handling to work better with Docker socket proxy wrappers (like those used in some CI environments such as custom GitHub runners with DinD).
Changes
SocketsHttpHandlerwithConnectCallbackinstead of the legacyManagedHandlerKeepAlivesocket option for better proxy compatibilitySocketConnectTimeoutproperty (default 30 seconds)Files Changed
DockerClientConfiguration.csSocketConnectTimeoutparameter/propertyDockerClient.csSocketsHttpHandlerfor .NET 8+, improvedManagedHandlerfor .NET StandardDockerClientConfigurationTests.csTest plan
🤖 Generated with Claude Code