Skip to content

Conversation

@alanivey
Copy link
Contributor

Description

Use the actual AWS partition for WAF log delivery policy instead of assuming "aws".

Motivation and Context

Allows WAF delivery (also works for VPC Flow Logs) policy to be used in other AWS partitions.

Breaking Changes

None, users on AWS commercial cloud will not have policies changed.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Also, I have deployed this in a GovCloud account and verified VPC Flow Log delivery occurs.

@alanivey alanivey changed the title Look up partition instead of hard-coded "aws" fix: look up partition instead of hard-coded "aws" Nov 24, 2025
@alanivey alanivey changed the title fix: look up partition instead of hard-coded "aws" Fix: look up partition instead of hard-coded "aws" Nov 24, 2025
@alanivey alanivey changed the title Fix: look up partition instead of hard-coded "aws" fix: Look up partition instead of hard-coded "aws" Nov 24, 2025
@bryantbiggs bryantbiggs changed the title fix: Look up partition instead of hard-coded "aws" fix: Replace static aws partition with dynamic data source Dec 12, 2025
@bryantbiggs bryantbiggs merged commit 77dfafa into terraform-aws-modules:master Dec 12, 2025
19 checks passed
antonbabenko pushed a commit that referenced this pull request Dec 12, 2025
## [5.9.1](v5.9.0...v5.9.1) (2025-12-12)

### Bug Fixes

* Replace static `aws` partition with dynamic data source ([#369](#369)) ([77dfafa](77dfafa))
@antonbabenko
Copy link
Member

This PR is included in version 5.9.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants