WIP terra-cli support for Drupal Console #123
Conversation
|
|
||
| // Write drush alias. | ||
| $drush_alias_file_path = "{$_SERVER['HOME']}/.drush/{$app_name}.aliases.drushrc.php"; | ||
| $drush_alias_file_path = "{$_SERVER['HOME']}/.drush/terra.{$app_name}.aliases.drushrc.php"; |
There was a problem hiding this comment.
Yes. sorry, this line is technically unrelated to this PR, but it is a bug. I can pull it out into a separate PR, if you want.
There was a problem hiding this comment.
It's fine this time.
When you see stuff like this just commit it separately. No need for a new PR, but I would be able to cherry-pick it out to master if it was in a separate commit.
|
Let me know if it works by having a console environments yml file! I don't think you would need console inside the container, but even if you did, it would only need a small patch to https://github.com/terra-ops/docker-drush to get added. |
jameswilson
force-pushed
the
drupal-console-support
branch
from
ed45fab to
3d2043f
Compare
|
I removed the unrelated commit into a separate PR #124 |
| * @return bool|mixed | ||
| */ | ||
| public function getDrupalConsolePort() | ||
| { |
There was a problem hiding this comment.
So, if i understand correctly the 'drush' image is just an SSH daemon, so you're saying we can just leverage the drush image. Maybe makes sense to rename the drush image to something more generic?
jameswilson
force-pushed
the
drupal-console-support
branch
from
3d2043f to
a2b0b63
Compare
|
So the console sites YML file doesn't work as I thought it would. And I'm not sure how to troubleshoot. One problem is i cant find a command to try to execute "remotely" because you have to be inside a drupal root in order to get access to a number of commands. But when you're inside a drupal root in your host machine filesystem thats being shared into a docker environment, and the settings.php file (or in my case settings.local.php file is modified to connect to a host called This seems to be a fundamental Drupal console issue, OR I'm probably doing something wrong 😄 I'd appreciate some feedback or insight from @jmolivas if you can shed some light on this. |
2 participants
Work in progress PR for #122