Docs Homepage Follow Up Feedback #4112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📖 Docs PR preview linksThis PR does not change any pages in /docs. If you make updates, links to the modified pages will appear here. |
davidcarlsonberg
changed the title
…emporalio/documentation into follow-up-docs-homepage-update
…to lighter weight. Reorganize some CSS.
Contributor
Author
|
Love the hover effect on the SDK logos! Going to merge this. |
lennessyy
added
the
visual-comparison
Contributor
|
📋 Visual Report for branch follow-up-docs-homepage-update with CI run 21010214058 and attempt 1 is ready at: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ticket: https://temporalio.atlassian.net/browse/GRWMK-167
Notes to reviewers
SdkLogos.jsfromgolang-block.svgtogolang.svgto match other SDK logos in the componentquickstartLinksarray fromHomePageHero.js@font-face)TODO
removedangerouslySetInnerHTML(probably don't need this as all content is in code [not user generated or from an external content source])