Adds a tool to create a simple task template #739

PuneetPunamiya · 2021-05-26T06:39:12Z

Signed-off-by: Puneet Punamiya ppunamiy@redhat.com

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Follows the authoring recommendations
Includes docs (if user facing)
Includes tests (if functionality of task changed or new task added)
Commit messages follow commit message best practices
Complies with Catalog Organization TEP, see example. Note An issue has been filed to automate this validation
- File path follows <kind>/<name>/<version>/name.yaml
- Has README.md at <kind>/<name>/<version>/README.md
- Has mandatory metadata.labels - app.kubernetes.io/version the same as the <version> of the resource
- Has mandatory metadata.annotations tekton.dev/pipelines.minVersion
- mandatory spec.description follows the convention
```
  ```
  
    spec:
      description: >-
        one line summary of the resource
  
        Paragraph(s) to describe the resource.
  ```
```

See the contribution guide
for more details.

tekton-robot · 2021-05-26T06:39:16Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign vdemeester
You can assign the PR to them by writing /assign @vdemeester in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vdemeester

/cc @tektoncd/catalog-maintainers

PuneetPunamiya · 2021-06-11T11:44:24Z

/hold cancel

PuneetPunamiya · 2021-06-11T12:25:03Z

/test pull-tekton-catalog-integration-tests

chmouel

Some nits about code, maybe you would like to do a class and some argpass for passing default argument, you can maybe get inspiration from this script if you want to snatch the parse_args/main and class function

chmouel · 2021-06-11T13:35:15Z

tools/tools.py

+json_object = json.loads(jsondata)
+
+# Type of resource
+type = input("Enter type of resource: task/pipeline: ").lower()


type is normally a reserver word in python :D

chmouel · 2021-06-11T13:36:11Z

tools/tools.py

+        metadata["annotations"]["tekton.dev/pipelines.minVersion"] = minPipelineVersion
+        metadata["annotations"]["tekton.dev/displayName"] = displayName
+
+    except OSError as error:


why don't you just os.path.exists the file instead of a try block?

chmouel · 2021-06-11T13:36:24Z

tools/tools.py

+        metadata["annotations"]["tekton.dev/displayName"] = displayName
+
+    except OSError as error:
+        print("""Resource with %s and version %s already exists""" %


you can use fstring instead

chmouel · 2021-06-11T13:41:00Z

I think ideally it would be best to include a README template as well and have a few argument, we could as plug inside cookicutter which would get us a lot of lifting :

https://github.com/cookiecutter/cookiecutter

For example for a default template on django https://github.com/pydanny/cookiecutter-django

Another idea, would be to just do this in go inside catlin (with go 1.5 embed stuff), having the validator near the linter (ie: same repo) is not a bad idea i think, so we can update easily the lint and the default template in a commit,

LucasG04 · 2021-06-26T07:09:21Z

tools/template.yaml

+      optional: true # Optional value of the workspace
+
+  params:
+    - name: '' # Name of parms


small typo

Suggested change

- name: '' # Name of parms

- name: '' # Name of param

- This patch adds a tool which help to create a manifest template for task/pipeline based on Tekton Catalog Organization Proposal Signed-off-by: Puneet Punamiya <ppunamiy@redhat.com>

tekton-robot · 2021-10-15T16:00:35Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

vinamra28 · 2021-10-18T11:10:40Z

/remove-lifecycle stale
@PuneetPunamiya any progress on this?

tekton-robot · 2022-01-16T11:31:28Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

vinamra28 · 2022-01-16T14:34:02Z

/remove-lifecycle stale
/lifecycle frozen

vinamra28 · 2022-03-14T06:53:19Z

since we are moving all these in catlin, @PuneetPunamiya can we close this?

tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 26, 2021

tekton-robot requested review from bobcatfish and dlorenc May 26, 2021 06:39

tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 26, 2021

PuneetPunamiya force-pushed the tool branch from d96a5b3 to c9ff587 Compare June 11, 2021 08:57

vdemeester reviewed Jun 11, 2021

View reviewed changes

tekton-robot requested a review from a team June 11, 2021 09:10

PuneetPunamiya force-pushed the tool branch 2 times, most recently from 00a675f to a00cbac Compare June 11, 2021 11:43

tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 11, 2021

PuneetPunamiya changed the title ~~[WIP] Adds a tool to create a simple task template~~ Adds a tool to create a simple task template Jun 11, 2021

tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 11, 2021

chmouel reviewed Jun 11, 2021

View reviewed changes

LucasG04 reviewed Jun 26, 2021

View reviewed changes

Adds a tool to create a task template

7bc7e6c

- This patch adds a tool which help to create a manifest template for task/pipeline based on Tekton Catalog Organization Proposal Signed-off-by: Puneet Punamiya <ppunamiy@redhat.com>

PuneetPunamiya force-pushed the tool branch from a00cbac to 7bc7e6c Compare July 2, 2021 10:22

tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 15, 2021

tekton-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 18, 2021

tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 16, 2022

tekton-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 16, 2022

Adds a tool to create a simple task template #739

Are you sure you want to change the base?

Adds a tool to create a simple task template #739

Uh oh!

Conversation

PuneetPunamiya commented May 26, 2021

Changes

Submitter Checklist

Uh oh!

tekton-robot commented May 26, 2021

Uh oh!

vdemeester left a comment

Choose a reason for hiding this comment

Uh oh!

PuneetPunamiya commented Jun 11, 2021

Uh oh!

PuneetPunamiya commented Jun 11, 2021

Uh oh!

chmouel left a comment

Choose a reason for hiding this comment

Uh oh!

chmouel Jun 11, 2021

Choose a reason for hiding this comment

Uh oh!

chmouel Jun 11, 2021

Choose a reason for hiding this comment

Uh oh!

chmouel Jun 11, 2021

Choose a reason for hiding this comment

Uh oh!

chmouel commented Jun 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LucasG04 Jun 26, 2021

Choose a reason for hiding this comment

Uh oh!

tekton-robot commented Oct 15, 2021

Uh oh!

vinamra28 commented Oct 18, 2021

Uh oh!

tekton-robot commented Jan 16, 2022

Uh oh!

vinamra28 commented Jan 16, 2022

Uh oh!

vinamra28 commented Mar 14, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

chmouel commented Jun 11, 2021 •

edited

Loading