Adapt pulp builds in copr as done in copr-cli
#4463
+96
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AthreyVinay
added
plugin | artifact
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
LecrisUT
approved these changes
Jan 7, 2026
Comment on lines
+194
to
+197
| except Exception: | ||
| # Idea is not to fail the whole process if results.json is missing | ||
| self.logger.warning(f"Failed to download: '{results_url}'.") | ||
| return [] |
Contributor
There was a problem hiding this comment.
Fine to raise in this case IMO.
Contributor
Author
There was a problem hiding this comment.
I agree, left it to continue since the copr-cli had done it.
See: https://github.com/fedora-copr/copr/blob/c3b10d50b5c24e4ab58c41699811b01ff1b27b4b/cli/copr_cli/main.py#L760
AthreyVinay
force-pushed
the
avinay-copr-pulp-support
branch
from
79e3032 to
5f5f89d
Compare
|
After the discussion with @thrix, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle pulp-based builds by fetching
results.jsonfor RPM URLs; non-Pulp (copr) behavior remains unchanged.Pull Request Checklist