Do not inject plan environment into test environment #4455
+11
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happz
added
code | style
16 tasks
happz
force-pushed
the
test-invocation-checks-moved
branch
from
9642993 to
8b5a98b
Compare
happz
force-pushed
the
plan-environment-decoupled-from-test
branch
from
9f1638e to
5cf11be
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
happz
force-pushed
the
plan-environment-decoupled-from-test
branch
from
5cf11be to
6ab53e0
Compare
happz
force-pushed
the
test-invocation-checks-moved
branch
from
8b5a98b to
d291881
Compare
This will present the same environment to all users of test invocation, from checks to test itself and its results. It was also not clear who is responsible for the environment and its composition, now when it's part of the invocation, all `execute` plugins should see the same content.
It is no longer merged into test environment. That leaves the test environment untainted and with its original content. The plan environment is then exposed to test when invoked, as any other environment component. Related to #4241.
happz
force-pushed
the
plan-environment-decoupled-from-test
branch
from
6ab53e0 to
f553a7c
Compare
LecrisUT
approved these changes
Jan 5, 2026
| def environment(self) -> Environment: | ||
| if self._environment is None: | ||
| # narrow type | ||
| parent = cast(Execute, self.phase.parent) |
Contributor
There was a problem hiding this comment.
Do we need the cast here if we are doing the assert isinstance?
| assert self.phase.parent.plan.my_run is not None | ||
| # narrow type | ||
| run = cast(tmt.base.Run, parent.plan.my_run) | ||
| assert run is not None |
Contributor
There was a problem hiding this comment.
If you could squeeze in a type annotation of the Plan, that could avoid the cast here too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is no longer merged into test environment. That leaves the test environment untainted and with its original content. The plan environment is then exposed to test when invoked, as any other environment component.
Related to #4241.
Pull Request Checklist