Add example tests for artifact providers

[vaibhavdaren]

Add simple, example-based integration tests for artifact providers:

• koji.build: Fetches packages from Koji using build IDs
• repository-url: Configures external package repositories
• multi: Demonstrates using multiple providers together

Once the design is approved, additional providers (koji.task, koji.nvr, file, copr.build, brew.*) can be added following the same pattern.

Related to #4420

[LecrisUT]

Is the goal for this PR to split the /tests/prepare/artifact into individual provider tests? If so, why not add it to it instead? For example you can add a for loop in the test.sh to loop over each provider if that is the intent.

One concern with the current approach is that the koji list-tagged logic is quite non-trivial and would prefer to be defined in a single place.

[LecrisUT]

We should not be installing from the script since this is uncontrolled by us.

[graphite-app]

Missing error check after calling get_koji_build_id. If the function fails (returns empty string), the test continues with an invalid koji.build: provider (missing build ID) which will cause the tmt run to fail with an unclear error message.

Fix by adding a check:

make_build_id=$(get_koji_build_id "make" "f${fedora_release}")
if [ -z "$make_build_id" ]; then
    rlDie "Failed to get koji build ID for make"
fi

Suggested change

	make_build_id=$(get_koji_build_id "make" "f${fedora_release}")
	rlPhaseEnd
	rlPhaseStartTest "Test koji.build provider"
	rlRun "tmt run -i $run --scratch -vv --all \
	provision -h $PROVISION_HOW --image $TEST_IMAGE_PREFIX/fedora/${fedora_release}:latest \
	prepare --how artifact --provide koji.build:$make_build_id" 0 "Run with koji.build provider"
	make_build_id=$(get_koji_build_id "make" "f${fedora_release}")
	if [ -z "$make_build_id" ]; then
	rlDie "Failed to get koji build ID for make"
	fi
	rlPhaseEnd
	rlPhaseStartTest "Test koji.build provider"
	rlRun "tmt run -i $run --scratch -vv --all \
	provision -h $PROVISION_HOW --image $TEST_IMAGE_PREFIX/fedora/${fedora_release}:latest \
	prepare --how artifact --provide koji.build:$make_build_id" 0 "Run with koji.build provider"

Spotted by Graphite Agent



Is this helpful? React 👍 or 👎 to let us know.

[graphite-app]

Missing error check after calling get_koji_build_id. If the function fails (returns empty string), the test continues with an invalid koji.build: provider (missing build ID) which will cause the tmt run to fail with an unclear error message.

Fix by adding a check:

make_build_id=$(get_koji_build_id "make" "f${fedora_release}")
if [ -z "$make_build_id" ]; then
    rlDie "Failed to get koji build ID for make"
fi

Suggested change

	make_build_id=$(get_koji_build_id "make" "f${fedora_release}")
	rlPhaseEnd
	rlPhaseStartTest "Test multiple providers"
	rlRun "tmt run -i $run --scratch -vv --all \
	provision -h $PROVISION_HOW --image $TEST_IMAGE_PREFIX/fedora/${fedora_release}:latest \
	prepare --how artifact \
	--provide koji.build:$make_build_id \
	--provide repository-url:https://download.docker.com/linux/fedora/docker-ce.repo" 0 "Run with multiple providers"
	make_build_id=$(get_koji_build_id "make" "f${fedora_release}")
	if [ -z "$make_build_id" ]; then
	rlDie "Failed to get koji build ID for make"
	fi
	rlPhaseEnd
	rlPhaseStartTest "Test multiple providers"
	rlRun "tmt run -i $run --scratch -vv --all \
	provision -h $PROVISION_HOW --image $TEST_IMAGE_PREFIX/fedora/${fedora_release}:latest \
	prepare --how artifact \
	--provide koji.build:$make_build_id \
	--provide repository-url:https://download.docker.com/linux/fedora/docker-ce.repo" 0 "Run with multiple providers"

Spotted by Graphite Agent



Is this helpful? React 👍 or 👎 to let us know.