reportportal schema should not require project key #4445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plugin schema since it can be specified in TMT_PLUGIN_REPORT_REPORTPORTAL_PROJECT environment var or on the commandline. The reportportal plugin code appears to alredy handle when the project key is not specified in any of the allowed forms. It throws an exception. The added test requires reportportal access and can be run locally.
back to the default test_tmt
tcornell-bus
added
step | report
tcornell-bus
changed the title
tcornell-bus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not require the project key in reportportal plugin schema since it can be specified in TMT_PLUGIN_REPORT_REPORTPORTAL_PROJECT environment var or on the command line.
The reportportal plugin code appears to already handle when the project key is not specified in any of the allowed forms. It throws an exception.
The added test requires reportportal access and can be run locally. Since I do not have access to
test_tmtreportportal project, I used my personal project for testing.I went down a rabbit hole of trying to fix the tests in
tests/report/reportportal/data/test.fmf, but it was taking a considerable amount of time. I am about halfway through fixing them, so I may follow up with a PR to fix those.Fixes: #4178
Pull Request Checklist